Dan Field

Results 553 comments of Dan Field

No, but it should probably be disabled by default for `flutter drive` invocations. This is aweird case where DDS wants to take over the observatory URI that the test is...

The basic problem is that passing a build context to anything that might hold on to it beyond when it's still mounted. this can happen with or without async work,...

That approach isn't feasible, since the most common uses for the build context are to get information about position in the tree - it's not a simple matter of copying...

As far as the framework usage of these things goes, the following code would work: ```dart Widget build(BuildContext context) { assert(identical(this.context, context)); } ``` The only time that would not...

Sure, accessing `this.context` after the state has been unmounted will return null, but if you leaked `this.context` before unmounting, it will remain leaked even after mounting. I'm wondering if we're...

But if you replaced it wouldn't the context still get retained in the closure and retain the state?

Ahh I think I misread your comment. Leaking the state is better than leaking the context because the context will unhook itself from the state. However, leaking the state is...

I'm seeing this issue in Flutter framework code - using from where we reallys hould use of because of extra type checking that is incurred by from.

If there's no existing way, it might be nice to have something like: ``` /// {@alias abstract class ReallyAMixin} ``` Or perhaps some other top level file that control such...