Daniel Nephin

Results 312 comments of Daniel Nephin

> I have used it a few times to verify that the right intermediate had signed a leaf I think you're referring to the `SigningKeyID` , right? We need to...

Ya, that test failure should be fixed in main. Let me rebase this to be sure.

Thank you for reporting this issue! The node health comes from the `serf` health check. `memberlist` and `serf` do not use the tcp port, and so don't make use of...

(Disclaimer: I am the author of [gotest.tools/v3/assert](https://pkg.go.dev/gotest.tools/v3/assert)) In case anyone is interested in a tool that does exactly this for a different assertion library [gty-migrate-from-testify](https://github.com/gotestyourself/gotest.tools/tree/main/assert/cmd/gty-migrate-from-testify) does this translation for `gotest.tools/v3/assert`....

@vdemeester what do you think? Any concerns with removing the `skip` package and moving the one function into `assert` ?

Fair point! My guess is that no one would really use the `skip` package on its own, because it doesn't do all that much. That's one of my main motivations...

A little while ago I considered adding something like `Implements` or `Type`. When I was experimenting with it I realized that most of the time if I cared about the...

You can have the compiler perform that test for you by adding this line to a package: ```go var _ DriverInterface = &YamlDriver{} ``` I believe that's the recommended practice...

A better example from #147 ```go doer, ok := something.(Doer) assert.Assert(t, ok, "got: %T", something) ``` ```go var _ DriverInterface = (*YamlDriver)(nil) ```

Hey Glen! Thanks for opening this issue, I think it's an interesting idea. I've worked with a few tests that have this problem. Often I see them either use a...