David Montague

Results 207 comments of David Montague

There are a lot of different pieces in play here (gunicorn, uvicorn, starlette, fastapi, socket.io, python, ...), each of which is potentially relevant to figuring out if there is a...

@tomplex thanks for sharing, that looks useful. I got excited about the idea of trying to merge it upstream, but noticed it was GPL licensed 😕.

Currently, this is one of the better options: https://fastapi.tiangolo.com/advanced/custom-request-and-route/#accessing-the-request-body-in-an-exception-handler but unfortunately there still isn't a *great* way to do this as far as I'm aware.

@amorey Depending on exactly what you want to do, you can either create a custom middleware that only does things before the request, or you can create a dependency that...

I think websocket support is an important part of the `TestClient`, so I think any migration needs a story around that (as @florimondmanca noted). I'm not sure whether websocket support...

Yeah, for what it's worth I *would* be happier to make use of a dedicated asgi test client package than to rely on other packages to patch necessary functionality into...

This looks great! There are some changes I think we should make before merging but I think it shouldn't be too hard to get it there. Don't worry too much...

Okay, it wasn't super straightforward, but I think I've mostly addressed this now in #3. The main change is that I've added a decorator called `generic_cbv` which you use to...

@bgorges Okay, I've got the above working with python 3.6; you can see the added test case in #3 for reference. I'll push a new release once I have a...

Hmm, actually, I think I can get rid of the separate decorator, and just use `@cbv(...)` in both cases. It would basically be set up so that if you inherit...