fastapi icon indicating copy to clipboard operation
fastapi copied to clipboard

[QUESTION] Use of socket.io

Open siedi opened this issue 5 years ago • 50 comments

Description

How can I use socket.io instead of the plain websocket integration? I guess this is more a question belonging to starlette.

Currently migrating from a flask application using flask-socketio / python-socketio

Any hint is appreciated. Thx.

siedi avatar Mar 31 '19 07:03 siedi

Socket-IO has an ASGI compatible app: https://python-socketio.readthedocs.io/en/latest/server.html#uvicorn-daphne-and-other-asgi-servers

You should be able to mount that app like if it was a FastAPI sub-application: https://fastapi.tiangolo.com/tutorial/sub-applications-proxy/#mount-the-sub-application

tiangolo avatar Mar 31 '19 17:03 tiangolo

Hi,

Also have a question regarding python-socketio, Ive tried:

sio = socketio.AsyncServer(async_mode='asgi')
sio_asgi_app = socketio.ASGIApp(sio, app)
app.mount("/api/socket.io", sio_asgi_app)

Which does indeed seem to work, but only partially. Only GET requests seems to get through and POST's are somehow blocked, I get:

INFO:uvicorn:('127.0.0.1', 51888) - "GET /api/socket.io/ HTTP/1.1" 200
INFO:uvicorn:('127.0.0.1', 51890) - "POST /api/socket.io/ HTTP/1.1" 405

Is there a way to also allow POST on /api/socket.io/ ?

Thanks

marcus-oscarsson avatar Apr 20 '19 19:04 marcus-oscarsson

I am unable to get this to work at all, even with the snippet above.

BlackHoleFox avatar Apr 21 '19 15:04 BlackHoleFox

I see, here is my complete example,

    app = FastAPI(debug=True)
    sio = socketio.AsyncServer(async_mode='asgi')
    sio_asgi_app = socketio.ASGIApp(sio, app, socketio_path="/api/socket.io")

    app.mount("/api/socket.io", sio_asgi_app)
    sio.register_namespace(ws.ConnectNS('/'))

Where the ws module contains:


class ConnectNS(socketio.AsyncNamespace):
    def on_connect(self, sid, environ):
        logging.debug("Websocket connected %s", sid)

    def on_disconnect(self, sid):
        logging.debug("Websocket disconnected %s" % sid)

I then run uvicorn with the app object, running it with sio_asgi_app works fine but the FastAPI app does not receive any traffic.

It seems that the routing mechanism in either FastAPI ot Starlette somehow only allows GET requests, but I might be wrong and I'm maybe doing something else wrong.

@BlackHoleFox: it did not work at all for me either until I noticed that second parameter of ASGIApp, which gets me to the currently partially working state ...

marcus-oscarsson avatar Apr 22 '19 10:04 marcus-oscarsson

Finally,

    sio = socketio.AsyncServer(async_mode='asgi')
    sio_asgi_app = socketio.ASGIApp(sio, app, socketio_path="/api/socket.io")
    sio.register_namespace(ws.ConnectNS('/'))

Works just fine if you use the ASGIApp object, It might maybe have other consequences but it seems to work fine for me so far. I had some other issues with the routing in my example application making it fail the first time i tried. I never got app.mount("/api/socket.io", sio_asgi_app) to work properly though.

marcus-oscarsson avatar Apr 22 '19 14:04 marcus-oscarsson

@marcus-oscarsson I ended up with the same results. I can directly use the ASGIApp with Uvicorn but the mounting method never passes through the requests properly and my client gets a Unexpected response from server whenever it attempts to connect. Seems the solution for me at the moment will be to run the socket backend and REST backend separately.

BlackHoleFox avatar Apr 22 '19 15:04 BlackHoleFox

@BlackHoleFox I see, I simply removed the app.mount(...) and I let the ASGIApp handle the rest. It works fine for me all running in the same process. So finally using the ASGIApp is a working solution for me.

marcus-oscarsson avatar Apr 23 '19 09:04 marcus-oscarsson

So are we giving up on app.mount(...)? ASGIApp is kind of work but it ends up with maintaining 2 applications Any idea to go further on this?

kientt86 avatar May 03 '19 17:05 kientt86

@kientt86 I would say that its up to the maintainer, @tiangolo, to decide exactly what to do with app.mount. I'm not sure if I used it correctly in my example so it could also simply be that I'm missing some option. It would be nice if it worked with app.mount since it would be more consistent.

Using the ASGIApp otherwise seems to work fine and one would still need to create and somehow handle it so I don't really see an issue with it

marcus-oscarsson avatar May 06 '19 08:05 marcus-oscarsson

Thanks for all the reports guys.

I want to check how to integrate Socket.IO and integrate it directly in the docs, I haven't had the time though, but I'll do it hopefully soon.

tiangolo avatar May 10 '19 17:05 tiangolo

I´m looking forward for this integrate. It would be great for the project.

cheers!

rudmac avatar Jun 01 '19 23:06 rudmac

This is more of a feature request but related to using python-socketio. flask-socketio comes with a test_client that makes testing very convenient (no need to manually spin up a server in a separate process, can emit events with callbacks, stores messages received from the server, etc.). Comparatively, starlette.testclient.TestClient is very basic.

Hoping this can be implemented on top of the general socket.io support. I wouldn't mind working on a PR for this, but would require some direction. Thanks!

databasedav avatar Jul 23 '19 20:07 databasedav

I'm struggling with getting this to work with FastAPI. I've tried this code:

fast_app = FastAPI(
    openapi_url='/api/notifications/openapi.json',
    docs_url='/api/notifications/docs',
    redoc_url='/api/notifications/redoc'
)
sio = socketio.AsyncServer(
    async_mode='asgi',
    cors_allowed_origins='*'
)
app = socketio.ASGIApp(
    socketio_server=sio,
    other_asgi_app=fast_app,
    socketio_path='/api/notifications/socket.io/'
)

Which allows me to connect to the socket.io endpoint, but when I attempt to connect to a FastAPI defined endpoint, it'll raise a traceback from python-engineio:

INFO: ('127.0.0.1', 64336) - "GET /api/notifications/openapi.json HTTP/1.1" 500
ERROR: Exception in ASGI application
Traceback (most recent call last):
  File "/Users/szelenka/anaconda3/envs/python37/lib/python3.7/site-packages/uvicorn/protocols/http/httptools_impl.py", line 368, in run_asgi
    result = await app(self.scope, self.receive, self.send)
  File "/Users/szelenka/anaconda3/envs/python37/lib/python3.7/site-packages/uvicorn/middleware/debug.py", line 96, in __call__
    raise exc from None
  File "/Users/szelenka/anaconda3/envs/python37/lib/python3.7/site-packages/uvicorn/middleware/debug.py", line 78, in __call__
    await self.app(scope, receive, inner_send)
  File "/Users/szelenka/anaconda3/envs/python37/lib/python3.7/site-packages/engineio/async_drivers/asgi.py", line 53, in __call__
    await self.other_asgi_app(scope, receive, send)
TypeError: __call__() takes 2 positional arguments but 4 were given

As best I can tell, engineio is attempting to call FastAPI with 4 parameters ('self', 'scope', 'receive', and 'send') .. while 0.33 version of FastAPI is simply using the Starlette call method that only accepts ('self' and 'scope').

I'm interested to learn what version other people (@marcus-oscarsson ) are using where this works inside FastAPI app.

I've managed to hack around it with this helper class:

from fastapi import FastAPI
from starlette.types import ASGIInstance, Scope, Receive, Send


class FastAPISocketIO(FastAPI):
    async def __call__(self, scope: Scope, receive: Receive, send: Send) -> ASGIInstance:
        fn = super(FastAPISocketIO, self).__call__(scope=scope)
        return await fn(receive=receive, send=send)

But it seems the problem is an incompatibility with Starlette and python-socketio?

szelenka avatar Aug 05 '19 18:08 szelenka

Turns out my problem was with Starlette.

Starlette version 0.11.1 needed the above hack, while version 0.12.0 doesn't have the problem and works without the above hack.

szelenka avatar Aug 06 '19 20:08 szelenka

A bit more complete example, based on @szelenka's work that might help other people. I don't like that it uses two apps but it seems to work.

'''
Run with:
uvicorn app_uvicorn_fastapi:app --reload --port 5000

'''
from starlette.staticfiles import StaticFiles
from fastapi import FastAPI
import uvicorn
import socketio

# There is some complexity in setting up Fastapi combined with socketio
# https://github.com/tiangolo/fastapi/issues/129

fast_app = FastAPI(
    openapi_url='/docs/openapi.json',
    docs_url='/docs/docs',
    redoc_url='/docs/redoc'
)
sio = socketio.AsyncServer(
    async_mode='asgi',
    cors_allowed_origins='*'
)
app = socketio.ASGIApp(
    socketio_server=sio,
    other_asgi_app=fast_app,
    socketio_path='/socket.io/'
)

@sio.event
def connect(sid, environ):
    print("connect ", sid, environ)

@sio.event
async def chat_message(sid, data):
    print("message ", data)
    await sio.emit('reply', room=sid)

@sio.event
def disconnect(sid):
    print('disconnect ', sid)


#  File serving, api serving by Fastapi etc

fast_app.mount("/static", StaticFiles(directory="static"), name="static")

@fast_app.get("/hello")
async def root():
    return {"message": "Hello World"}

mjmare avatar Oct 30 '19 09:10 mjmare

Any news? I look forward to it working.

GustavoCarvalho avatar Oct 30 '19 15:10 GustavoCarvalho

@mjmare Very good... that's works perfectly using uvicorn.

But with gunicorn WSGI got some errors:

[2019-11-19 14:50:51 +0000] [23] [ERROR] Exception in ASGI application
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/uvicorn/protocols/websockets/websockets_impl.py", line 146, in run_asgi
    result = await self.app(self.scope, self.asgi_receive, self.asgi_send)
  File "/usr/local/lib/python3.7/site-packages/uvicorn/middleware/message_logger.py", line 58, in __call__
    raise exc from None
  File "/usr/local/lib/python3.7/site-packages/uvicorn/middleware/message_logger.py", line 54, in __call__
    await self.app(scope, inner_receive, inner_send)
  File "/usr/local/lib/python3.7/site-packages/engineio/async_drivers/asgi.py", line 46, in __call__
    await self.engineio_server.handle_request(scope, receive, send)
  File "/usr/local/lib/python3.7/site-packages/socketio/asyncio_server.py", line 326, in handle_request
    return await self.eio.handle_request(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/engineio/asyncio_server.py", line 297, in handle_request
    r['response'], environ)
  File "/usr/local/lib/python3.7/site-packages/engineio/async_drivers/asgi.py", line 168, in make_response
    'headers': headers})
  File "/usr/local/lib/python3.7/site-packages/uvicorn/middleware/message_logger.py", line 49, in inner_send
    await send(message)
  File "/usr/local/lib/python3.7/site-packages/uvicorn/protocols/websockets/websockets_impl.py", line 213, in asgi_send
    raise RuntimeError(msg % message_type)
RuntimeError: Expected ASGI message 'websocket.send' or 'websocket.close', but got 'http.response.start'.

After some testing, I'm using this code:

app = FastAPI(
    title=config.PROJECT_NAME,
    description=config.PROJECT_NAME,
    version=config.PROJECT_VERSION,
    debug=True
)

sio = socketio.AsyncServer(
    async_mode='asgi',
    cors_allowed_origins=','.join(config.ALLOW_ORIGIN)
)

sio_asgi_app = socketio.ASGIApp(
    socketio_server=sio,
    other_asgi_app=app
)

app.add_route("/socket.io/", route=sio_asgi_app, methods=['GET', 'POST'])
app.add_websocket_route("/socket.io/", sio_asgi_app)

kind off working with gunicorn...

sometimes, got the error above...

I will keep trying and let you guys know...

Cheers

rudmac avatar Nov 19 '19 16:11 rudmac

Can anyone provide some insight into whether they've gotten this to work well with a synchronous database connection (I'm using SQLAlchemy ORM) and what it takes to ensure thread-safety?

acnebs avatar Nov 26 '19 07:11 acnebs

RuntimeError: Expected ASGI message 'websocket.send' or 'websocket.close', but got 'http.response.start'.

kind off working with gunicorn... sometimes, got the error above...

I'm receiving the same error with running using Gunicorn. Running with Uvicorn doesn't get me the same response.

shawnd avatar Dec 11 '19 01:12 shawnd

I'm struggling with the same problem :( If I have 4 workers (gunicorn -w 4 ...) this error almost always happens. For 1 worker it rarely (or maybe never) does.

antnieszka avatar Jan 09 '20 17:01 antnieszka

Has there been any update on this? Still struggling to find a complete working example. Thanks.

jackdh avatar Jan 19 '20 11:01 jackdh

There are a lot of different pieces in play here (gunicorn, uvicorn, starlette, fastapi, socket.io, python, ...), each of which is potentially relevant to figuring out if there is a problem.

My strong suspicion is that this issue is not specific to FastAPI, but rather is a problem with uvicorn or starlette. It's probably worth trying to replicate the problem using just starlette and/or creating an issue in the starlette repo asking for guidance.

At any rate, if you are having an issue and want help, please post the versions of each of the various dependencies you are using. That may not be enough to help resolve the issue, but as things stand it's basically impossible to help without knowing more.

dmontagu avatar Jan 21 '20 10:01 dmontagu

I had the same problem using the given example so I started from the python-socketio asgi example and added fastapi and it works :tada:

I upgraded a few packages compared to the example and here is my requirements.txt:

Click==7.0
fastapi==0.54.1
h11==0.8.1
httptools==0.1.1
pydantic==1.5.1
python-engineio==3.12.1
python-socketio==4.5.1
six==1.11.0
starlette==0.13.2
uvicorn==0.11.5
uvloop==0.14.0
websockets==8.1

And then the code is the example app.py mounted in a fastapi app (partial copy):

#!/usr/bin/env python 
import socketio    
from fastapi import FastAPI    
    
    
app = FastAPI()    
    
sio = socketio.AsyncServer(async_mode='asgi')    
socket_app = socketio.ASGIApp(sio, static_files={'/': 'app.html'})    
background_task_started = False    
    
    
async def background_task():    
<... EXACTLY LIKE app.py IN python-socketio/examples/server/asgi ...>

@sio.on('disconnect')
def test_disconnect(sid):
    print('Client disconnected')


@app.get("/hello")
async def root():
    return {"message": "Hello World"}


app.mount('/', socket_app)

Then used uvicorn fast_app:app --reload --host 0.0.0.0 and all good. All features seem to work properly.

hillairet avatar Apr 29 '20 17:04 hillairet

This example works perfectly! Thank you boss.

vlori2k avatar Aug 19 '20 01:08 vlori2k

Hello I m trying to mount the socketio as a sub application on top of a Fast API app, and it doesn't seem to work. Although if I dont mount it and run as a separate application it is just fine. Can some one comment on it? Have you faced the same issue before? Here is my code. Server:

from fastapi import FastAPI
import uvicorn
import socketio

app = FastAPI(title="Core Stack", version="1.0.0")


@app.get("/", include_in_schema=False)
async def hello():
    return {"message": "Hello, world's best developer!"}


sio = socketio.AsyncServer(async_mode="asgi")
subapi = socketio.ASGIApp(sio)

app.mount("/subapi", subapi)


@sio.event
def my_event(sid, data):
    pass


@sio.on("connect")
def connect(sid, environ):
    print("connected", sid)


@sio.on("disconnect")
def disconnect(sid):
    print("disconnect", sid)

Client:

import socketio

sio = socketio.Client()


@sio.event
def connect():
    print("connection established")


@sio.event
def my_message(data):
    print("message received with ", data)
    sio.emit("my response", {"response": "my response"})


@sio.event
def disconnect():
    print("disconnected from server")


sio.connect("http://127.0.0.1:8000/subapi/")
sio.wait()

Error I get on Server side:

127.0.0.1:34844 - "GET /socket.io/?transport=polling&EIO=3&t=1602760515.7113314 HTTP/1.1" 404 Not Found

Here is the error I get on client side:

Traceback (most recent call last):
  File "src/tests/client_test.py", line 22, in <module>
    sio.connect("http://127.0.0.1:8000/subapi/")
  File "/home/harry/.cache/pypoetry/virtualenvs/core-stack-g4U8Q-rv-py3.8/lib/python3.8/site-packages/socketio/client.py", line 282, in connect
    six.raise_from(exceptions.ConnectionError(exc.args[0]), None)
  File "<string>", line 3, in raise_from
socketio.exceptions.ConnectionError: Unexpected status code 404 in server response

Harsha-BR avatar Oct 15 '20 11:10 Harsha-BR

I produced a complete example with unit tests in this comment of issue miguelgrinberg/python-socketio#332, although it doesn't use TestClient.websocket for testing, but the standard python-socketio client. Currently, for this to work, it needs to run a local uvicorn server, but starting and stopping should be extremely fast. (Just make sure that the port is free.) The UvicornTestServer class is rather reusable and extremely simple to setup, especially with pytest. Make sure you have the pytest-asyncio package installed. An example could be:

import pytest
from test.utils import UvicornTestServer

@pytest.fixture
async def start_stop_server():
    """Start server as test fixture and tear down after test"""
    server = UvicornTestServer()   # use 'port' kwarg to set alternative port, default is 8000
    await server.up()
    yield
    await server.down()

@pytest.mark.asyncio
async def test_method1(start_stop_server):
    """A simple http test"""
    # your test goes here
    # the gotcha here is that you can't use request.get, because it would block
    import aiohttp
    async with aiohttp.ClientSession() as session:
        async with session.get('http://localhost:8000/mytest') as response:
            assert response.status == 200
            content = await response.text()
            assert 'my test' in content



erny avatar Oct 20 '20 18:10 erny

@Harsha-BR, try to sio.connect('http://localhost:8000', socketio_path='/subapi/socket.io/')

erny avatar Oct 20 '20 18:10 erny

simple example

FastApi-Socket.io Server

import socketio
from fastapi import FastAPI
from socketio.asyncio_namespace import AsyncNamespace
from pydantic import BaseModel, ValidationError
from typing import Any
from logging import info

app = FastAPI()


class PacketModel(BaseModel):
    content: Any
    content_type: str


class GreyRookNameSpace(AsyncNamespace):
    # functions that have on_ prefix recognized as event
    async def on_connect(self, sid, *args, **kwargs):  # on connect event
        info(f"{sid}: Welcome!:)")

    async def on_disconnect(self, sid):  # on disconnect event
        info(f"{sid}: Bye!:(")

    async def on_packet(self, environ, *args, **kwargs):  # on packet event
        try:  # Packet Validation
            packet = PacketModel(**args[0])
        except ValidationError as ex:
            return PacketModel(
                content=str(ex.args), content_type="application/txt"
            ).dict()  # Call-Back
        await self.process_packet(packet)
        # await self.emit(
        #     "message", packet.dict(), namespace=self.namespace
        # )  # Emit to name-space
        return PacketModel(
            content="Delivered", content_type="application/txt"
        ).dict()  # Call-Back

    async def process_packet(self, packet: PacketModel):
        # some processing on packet
        # store in db
        # stream processing
        # upload chunks
        # etc
        pass


mgr = socketio.AsyncRedisManager(
    "redis://localhost/0"
)  # Message Queue is for working with distributed applications
sio = socketio.AsyncServer(
    async_mode="asgi", cors_allowed_origins="*"
)
sio.register_namespace(GreyRookNameSpace("/GreyRook"))  # register the namespace
asgi = socketio.ASGIApp(sio)

app.mount("/ws", asgi)  # mount Socket.Io to FastApi with /ws path


class SampleResponseModel(BaseModel):
    message: str


class Sample400ResponseModel(BaseModel):
    detail: str


@app.get("/", description="some description",
         responses={200: {'model': SampleResponseModel},
                    400: {'model': Sample400ResponseModel}})
async def index():
    return {"message": "Welcome to GreyRook!"}


"""
gunicorn app:app -w 1 -k uvicorn.workers.UvicornWorker --bind 0.0.0.0:3001  
horizontal scaling is the solution for high scale architecture
issue:  https://github.com/miguelgrinberg/Flask-SocketIO/issues/267#issuecomment-220525641
"""

Python Client

import socketio
from app import PacketModel

sio = socketio.Client()
sio.connect(
    "http://localhost:3001/ws", namespaces="/GreyRook", socketio_path="/ws/socket.io"
)


@sio.on("message", namespace="/GreyRook")
def new_packet(packet):
    print("\nMessage: ", packet)


def call_back(data):
    print("\ncall-back", data)


while True:
    msg = input("Message: ")
    sio.emit(
        "packet",
        PacketModel(content={"message": msg}, content_type="application/json").dict(),
        namespace="/GreyRook",
        callback=call_back,
    )

js

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <title>Title</title>
    <script src="https://cdnjs.cloudflare.com/ajax/libs/socket.io/2.3.1/socket.io.js"></script>
</head>
<body>
<script>
    socket = io('http://localhost:3001/ws', {
        path: '/ws/socket.io'
    });
</script>
</body>
</html>

includeamin avatar Oct 22 '20 17:10 includeamin

Thanks @erny and @includeamin your suggestions helped. Its working. :)

Harsha-BR avatar Oct 22 '20 23:10 Harsha-BR

TL;DR paths are important, beware of mounting it in / as it may cause issues.

Mounting it outside of / made it work for me on the first try for both uvicorn and gunicorn and it also allowed me to see what my particular issue was. Thanks for @includeamin for helping me figure it out on my side.

sio = socketio.AsyncServer(async_mode='asgi', cors_allowed_origins="*")
app.mount("/ws", socketio.ASGIApp(sio))

Will yield a connection in /ws/socket.io and will play nicely with other routes in / If you try to mount it on app.mount("/socket.io", socketio.ASGIApp(sio)), this will yield a path in the form of /socket.io/socket.io because of socketio_path='socket.io' by default so you'd have to change your client's path accordingly.

Problems may arise if you have any kind of rules/middleware/etc. that apply to /* such as the RuntimeError: Expected ASGI message 'websocket.send' or 'websocket.close', but got 'http.response.start'. error I saw here.

samypr100 avatar Oct 23 '20 20:10 samypr100

EVENT 1: (if other_asgi_app arg)

Server:
app = FastAPI()
sio = socketio.AsyncServer(async_mode='asgi', cors_allowed_origins='*')
sio_asgi_app = socketio.ASGIApp(sio, other_asgi_app=app, socketio_path='socket.io')
app.mount("/", sio_asgi_app)
uvicorn.run(app='main:app', host="0.0.0.0", port=7777, reload=True)
Client:
sio = socketio.Client()
sio.connect('http://127.0.0.1:7777/' , socketio_path='some nonexistent socketio_path')
sio.wait()

The Server raise an exception: <Current thread 0x00007fc4bab0d280 (most recent call first):> Server err shutdown

EVENT 2: (not other_asgi_app arg)

Server:
app = FastAPI()
sio = socketio.AsyncServer(async_mode='asgi', cors_allowed_origins='*')
sio_asgi_app = socketio.ASGIApp(sio, socketio_path='socket.io')
app.mount("/", sio_asgi_app)
uvicorn.run(app='main:app', host="0.0.0.0", port=7777, reload=True)
Like EVENT1 Client

The Server none any exceptions, only raise <404 Not Found> console message

mylot-python avatar Oct 30 '20 05:10 mylot-python

@includeamin I tried the simple example you provided but I get [ERROR] ASGI callable returned without starting response. with a 500 internal server error when the js client tries to initiate the websocket. Has anyone else experienced this?

MatthewScholefield avatar Nov 24 '20 22:11 MatthewScholefield

@includeamin I tried the simple example you provided but I get [ERROR] ASGI callable returned without starting response. with a 500 internal server error when the js client tries to initiate the websocket. Has anyone else experienced this?

did you run exactly my sample code? did you use this command ?gunicorn app:app -w 1 -k uvicorn.workers.UvicornWorker --bind 0.0.0.0:3001

includeamin avatar Nov 24 '20 22:11 includeamin

Oh, whoops, yeah you're right, there were a few problems I figured out:

  • I was using the latest socket.io javascript library which recently bumped to major version 3 (incompatible)
  • I needed to run pip3 install uvicorn[standard] (or just pip install websockets) to actually support websockets so it wouldn't resort to long polling
  • I was proxying the frontend and backend together using nginx. I needed to add some config values:
        proxy_http_version 1.1;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection "upgrade";

MatthewScholefield avatar Nov 25 '20 00:11 MatthewScholefield

There are a lot of different pieces in play here (gunicorn, uvicorn, starlette, fastapi, socket.io, python, ...), each of which is potentially relevant to figuring out if there is a problem.

My strong suspicion is that this issue is not specific to FastAPI, but rather is a problem with uvicorn or starlette. It's probably worth trying to replicate the problem using just starlette and/or creating an issue in the starlette repo asking for guidance.

At any rate, if you are having an issue and want help, please post the versions of each of the various dependencies you are using. That may not be enough to help resolve the issue, but as things stand it's basically impossible to help without knowing more.

@dmontagu exactly. I had the same problems, but then I tried to get all the dependencies with versions provided by @hillairet. Finally, it's working now, huh...

makusudi avatar Dec 21 '20 23:12 makusudi

Hello, I am trying to write unittests for socketio, I tried every solution here and nothing works, generally python client cannot connect to server.

import socketio
import uvicorn
from fastapi import FastAPI

sio = socketio.AsyncServer(async_mode="asgi")
app = FastAPI()
app.mount("/", socketio.ASGIApp(sio))

@sio.on("connect")
def connect(sid, environ):
    print("User connected")

if __name__ == "__main__":
    uvicorn.run(app) # python app:app`
import asyncio
import socketio

sio = socketio.AsyncClient(logger=True, engineio_logger=True)

async def fun():
    await sio.connect("http://127.0.0.1:8000")
    await.sleep(1)  # <-- That fixed the problem
    await sio.emit("a", "a")  

loop = asyncio.get_event_loop()
loop.run_until_complete(asyncio.gather(fun()))

Generally running connect connects to app

INFO:     127.0.0.1:55317 - "GET /socket.io/?transport=polling&EIO=4&t=1611532901.6567721 HTTP/1.1" 200 OK
INFO:     ('127.0.0.1', 55317) - "WebSocket /socket.io/" [accepted]

but it looks like it connects to another app, cause User connected is not printed and emiting raises socketio.exceptions.BadNamespaceError: / is not a connected namespace. Not sure what can be wrong, js client works perfectly with such server setup. I am working on MacOS, can it cause some troubles?

Edit: For everyone having problem with BadNamespaceError, it was caused emit was send before connect finished, adding asyncio.sleep fixed the problem.

kosciej16 avatar Jan 25 '21 00:01 kosciej16

I couldn't find that information anywhere: Is there a chance that /docs will be automatically generated for app that mounts socketio app?

kosciej16 avatar Jun 23 '21 23:06 kosciej16

I have integrated socketio with the fastapi core.

pip install "fastapi[socketio] @ git+https://github.com/bnnk/fastapi"

Then, after installation, to use:

from fastapi.websocketio import SocketIOMerger
<...  code here  ...>
app = SocketIOMerger(app, <... socketio instance variable ...>)

bnnk avatar Oct 10 '21 04:10 bnnk

I had the same problem using the given example so I started from the python-socketio asgi example and added fastapi and it works tada

I upgraded a few packages compared to the example and here is my requirements.txt:

Click==7.0
fastapi==0.54.1
h11==0.8.1
httptools==0.1.1
pydantic==1.5.1
python-engineio==3.12.1
python-socketio==4.5.1
six==1.11.0
starlette==0.13.2
uvicorn==0.11.5
uvloop==0.14.0
websockets==8.1

And then the code is the example app.py mounted in a fastapi app (partial copy):

#!/usr/bin/env python 
import socketio    
from fastapi import FastAPI    
    
    
app = FastAPI()    
    
sio = socketio.AsyncServer(async_mode='asgi')    
socket_app = socketio.ASGIApp(sio, static_files={'/': 'app.html'})    
background_task_started = False    
    
    
async def background_task():    
<... EXACTLY LIKE app.py IN python-socketio/examples/server/asgi ...>

@sio.on('disconnect')
def test_disconnect(sid):
    print('Client disconnected')


@app.get("/hello")
async def root():
    return {"message": "Hello World"}


app.mount('/', socket_app)

Then used uvicorn fast_app:app --reload --host 0.0.0.0 and all good. All features seem to work properly.

i get recursion error as soon as i do app.mount(......)

targhs avatar Dec 07 '21 19:12 targhs

I got this implemented like this. I am using react as frontend

targhs avatar Jan 05 '22 19:01 targhs

I have integrated socketio with the fastapi core.

pip install "fastapi[socketio] @ git+https://github.com/bnnk/fastapi"

Then, after installation, to use:

from fastapi.websocketio import SocketIOMerger
<...  code here  ...>
app = SocketIOMerger(app, <... socketio instance variable ...>)

Will it be merged with core??

INF800 avatar Jan 19 '22 17:01 INF800

@includeamin Thanks for solution, I have to correct js client for newer versions: (for python-socketio = 5.x and js socketio=4.x) Connection worked for me with io first parameter url without "/ws" at the end of the path for default namespace :

<script>
     socket = io('http://localhost:3001', {  // <- url parameter is not 'http://localhost:3001/ws'
         path: '/ws/socket.io'
     });
</script>

Otherwise, client thinks /ws is a namespace and altough connection is succesful, server side does not respond to client requests, since namespace doesn't exist on the server side.

For custom namespaces :

<script>
     socket = io('http://localhost:3001/GreyRook', {  // <-to connect GreyRook namespace
         path: '/ws/socket.io'
     });
</script>

tekmen0 avatar May 20 '22 07:05 tekmen0

can anybody say any simple implementation of fastApi (uvicorn server ) with simple python client .

cap-ma avatar Jul 05 '22 06:07 cap-ma

Do you know how to add Fastapi Dependencies on socketio endpoints similar to default Fastapi websockets?

jonra1993 avatar Jul 09 '22 20:07 jonra1993

can anybody say any simple implementation of fastApi (uvicorn server ) with simple python client .

This one should works for you.

kosciej16 avatar Jul 13 '22 08:07 kosciej16

You could check this one integrated into authx

yezz123 avatar Jul 13 '22 23:07 yezz123

Thanks @kosciej16 @yezz123 I am going to check your links

jonra1993 avatar Jul 18 '22 19:07 jonra1993

Hey, I dont get it working with the URL path and I dont know why. There is always the 404 Not Found error :( Perhaps you can help me @tekmen0 ?

Thanks for you help in advanced

So this is my code in a nutshell:

socket_server.py

# File socket_server.py
import socketio

sio = socketio.AsyncServer(async_mode="asgi", cors_allowed_origins="*")
asgi = socketio.ASGIApp(sio)

@sio.on("connect")
def connect(sid, environ, auth) -> None:
    print(f"Socket connected: {sid}")

application.py (mount at the bottom)

# File application.py where you get the FastAPI app
from sockets.socket_server import asgi

def get_app() -> FastAPI:

  app = FastAPI(
      docs_url="/api/docs",
      redoc_url="/api/redoc",
      openapi_url="/api/openapi.json",
      default_response_class=UJSONResponse,
  )
  
  # Disable Docs
  if settings.environment != "dev":
      app.openapi_url = None
  
  # Adds startup and shutdown events.
  register_startup_event(app)       # Just create folders if not exist
  register_shutdown_event(app)
  
  # Main router for the API.
  app.include_router(router=api_router, prefix="/api")
  
  # add static files
  app.mount("/static", StaticFiles(directory="/static"), name="static")
  app.mount("/", StaticFiles(directory="/pages"), name="pages")
  
  # add websocket
  app.mount("/ws", asgi, name="socket")
  
  return app

JS

const socket = io.connect('http://' + document.domain + ':' + location.port, {
    path: '/ws/socket.io'
});

And this is my error: Server:

2022-07-22 13:17:46.118 | INFO     | uvicorn.protocols.http.httptools_impl:send:437 - 127.0.0.1:33880 - "GET /ws/socket.io/?EIO=4&transport=polling&t=O8c3fJg HTTP/1.1" 404

Client:

socket.io.min.js:6          GET http://localhost:8000/ws/socket.io/?EIO=4&transport=polling&t=O8c58XL 404 (Not Found)

Versions I use:

python = 3.9
uvicorn = 0.17.5
python-socketio = 5.7.1
------------------
Socket.IO = 4.5.1

Floskinner avatar Jul 22 '22 13:07 Floskinner

Hello @Floskinner you can try with this configuration at client side.

image

"transports": ["websocket", "polling", "flashsocket"] did it work in my case

jonra1993 avatar Jul 24 '22 15:07 jonra1993

Hello @jonra1993 thanks for your help! I got it woking now :)

...but I also got another error and if anyone gets the same error, here is my solution / hint:


Error message:

ERROR:    Exception in ASGI application
Traceback (most recent call last):
  File "/workspaces/ifmDataLogger/.venv/lib/python3.9/site-packages/uvicorn/protocols/websockets/websockets_impl.py", line 184, in run_asgi
    result = await self.app(self.scope, self.asgi_receive, self.asgi_send)
  File "/workspaces/ifmDataLogger/.venv/lib/python3.9/site-packages/uvicorn/middleware/proxy_headers.py", line 75, in __call__
    return await self.app(scope, receive, send)
  File "/workspaces/ifmDataLogger/.venv/lib/python3.9/site-packages/fastapi/applications.py", line 261, in __call__
    await super().__call__(scope, receive, send)
  File "/workspaces/ifmDataLogger/.venv/lib/python3.9/site-packages/starlette/applications.py", line 112, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/workspaces/ifmDataLogger/.venv/lib/python3.9/site-packages/starlette/middleware/errors.py", line 146, in __call__
    await self.app(scope, receive, send)
  File "/workspaces/ifmDataLogger/.venv/lib/python3.9/site-packages/starlette/exceptions.py", line 58, in __call__
    await self.app(scope, receive, send)
  File "/workspaces/ifmDataLogger/.venv/lib/python3.9/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
    raise e
  File "/workspaces/ifmDataLogger/.venv/lib/python3.9/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
    await self.app(scope, receive, send)
  File "/workspaces/ifmDataLogger/.venv/lib/python3.9/site-packages/starlette/routing.py", line 656, in __call__
    await route.handle(scope, receive, send)
  File "/workspaces/ifmDataLogger/.venv/lib/python3.9/site-packages/starlette/routing.py", line 408, in handle
    await self.app(scope, receive, send)
  File "/workspaces/ifmDataLogger/.venv/lib/python3.9/site-packages/starlette/staticfiles.py", line 86, in __call__
    assert scope["type"] == "http"
AssertionError
INFO:     connection open
INFO:     connection closed

With loguru i can see scope["type"] is websocket

    assert scope["type"] == "http"
           └ {'type': 'websocket', 'asgi': {'version': '3.0', 'spec_version': '2.3'}, 'http_version': '1.1', 'scheme': 'ws', 'server': ('1...

Solution:

I also have to change the order of my route mounts: Befor:

  # Main router for the API.
  app.include_router(router=api_router, prefix="/api")
  
  # add static files
  app.mount("/static", StaticFiles(directory="/static"), name="static")
  app.mount("/", StaticFiles(directory="/pages"), name="pages")
  
  # add websocket
  app.mount("/ws", asgi, name="socket")

After:

  # Main router for the API.
  app.include_router(router=api_router, prefix="/api")

  # add websocket
  app.mount("/ws", asgi, name="socket")
  
  # add static files
  app.mount("/static", StaticFiles(directory="/static"), name="static")
  app.mount("/", StaticFiles(directory="/pages"), name="pages")

Ref: https://github.com/encode/starlette/issues/1548 and https://www.starlette.io/routing/#route-priority

Floskinner avatar Jul 25 '22 08:07 Floskinner