Dmitri Shuralyov
Dmitri Shuralyov
I'm not sure if we should be generating output that uses image URLs from the internet, or serving the emojis ourselves so they work even when offline. GitHub's API obviously...
> My need is that it should work offline, nothing else. I want to use it on my internal network :-) I'm okay with going with the offline-capable solution, if...
From an email, > This is @thewhitetulip, I started working on adding emojis to your excellent library, but when I actually started reading the code, I couldn't understand how it...
Is it relevant whether this is already implemented in other tools or not? (Given #149, I suspect not, but wanted to confirm.)
I'm not sure, but I suspect either vet or lint may make a suggestion that may be close (but the scope of its check is likely different). Since it's not...
Thanks for reporting this issue @itsksaurabh. We've had a similar situation in the past, so I wanted to ask some questions to better understand why it has come up again....
Sure, let's reopen it until we understand this better.
Thanks for answering. If I understand your reply correctly, you're suggesting there are no known reproducible situations when the response body isn't read completely by this library. That is good...
> the go repository What repository exactly? > How are the tests set up? I am unable to test the individual test files here. I am running these tests locally....
> I am sorry for spelling out the repository wrong. I am using the go-github repository. No problem, I just wanted to make sure I'm not misunderstanding you. > Is...