Dmitri Shuralyov

Results 869 comments of Dmitri Shuralyov

I could special-case the Go Package Store import path, and do something differently for it. But I feel that isn't as great as a more general solution. Perhaps [`binstale`](https://github.com/shurcooL/binstale) can...

> But I'm worried that might install too many unwanted binaries into `$GOPATH/bin`. Thoughts? Oooh, I have a great idea! I could do the following. When updating repos that contain...

> The only downside is that it's possible to mistakenly overwrite the wrong binary, in case of a command naming ambiguity. It might be possible to resolve that ambiguity by...

This is a feature I'd like to implement someday, and I'm using this issue to track the progress towards that. It's not done yet. I'd like to keep it open...

Hi @IaBurton, > I noticed here that there's a TODO for garbage collection. > https://github.com/shurcooL/trayhost/blob/master/trayhost.go#L152 > > It seems that the display function always appends the value of the struct...

> The point of appending it into the slice in the first place is so Go has a reference and doesn't GC it while the C code is using it...

I'm not seeing a check that would report this in the latest version of staticcheck or anywhere. @dominikh, do you know/remember what happened to it? Is it still valid, or...

> you don't need ReadFull because it's UDP, which is message based. Yes, that's what assumed when I wrote the code, and it seems to work without issues. But it...

Is that why this never made it into a production-ready staticcheck check?

This is a known behavior of `blackfriday`. Unlike GitHub's markdown parser, it requires indent to be of size 4 spaces or 1 tab at minimum. GitHub requires a minimum of...