Dmitri Shuralyov

Results 869 comments of Dmitri Shuralyov

@cheshire137 Yes, that should work if you use the suggestion @paultyng posted above. Please feel free to let me know if there's more to it.

I don't see anything wrong in that snippet. Having to create a local variable when optional fields have constant enum values is unfortunate (and maybe should be improved, in a...

@seanpile has already created PR #8 that resolves this issue. In it, he mentioned: > This is a backward compatible change, although you could argue that operation name should be...

Thanks for the PR. I'll try to get to reviewing it, but it may not happen right away. I hope you don't mind continuing to use your fork in the...

The main reason they're a Go value is so that you can access the query response by using that Go value. Other approaches are certainly possible and can be explored....

Yes, a GraphQL query → Go type tool (with a UI similar to https://mholt.github.io/json-to-go/; CC @mholt) is very possible and likely a good idea, as it'd help eliminate the manual...

Hi, thanks for the PR. I'd like to understand this better, so we can implement a better solution. Can you tell me under what conditions a non-200 response code is...

There are a few reasons I can't merge this PR yet: - It has correctness issues. Namely, the current code tries to do `ioutil.ReadAll(resp.Body)` after the `resp.Body` reader was already...

@jorgesece and @robermorales, I've merged PR #30, which should help. Please let me know if it works for your needs, or if doesn't completely cover them.

I'm warming up to this idea, but in a slightly different form. I think it might be a good idea to expose some of the graphql internals (in this project),...