Dmitri Shuralyov
Dmitri Shuralyov
Friendly ping @neelance. Somewhat related is #617 (/cc @myitcv). That issue is about internalization (JS -> Go), this is a question about externalization (Go -> JS).
> I didn't notice any problem with dead code elimination (on my current project, the generated javascript code has slightly the same size), but I'm not sure if there are...
Overall, this looks really good! Thanks for working on this @r-l-x. I've left some comments that came to mind looking at it, but this is a great start.
I haven't tried and don't know if it's possible, but can you change the kind of a top-level package identifier? E.g., the real `sha256.Sum256` in https://godoc.org/crypto/sha256#Sum256 is a `func`: ```Go...
> This is feasible, but I guess that could come in a second (probably more controversial) PR. What do you think ? I agree, let's leave out additional enhancements for...
> What do you think ? It sounds to me like always going with webcrypto when it's available is preferable. I like it more because it's conceptually simpler and more...
I was about to say exactly what @flimzy said above. Try rebasing this on top of latest master. If it's still an issue on the latest master, please file an...
> @shurcooL @flimzy You are right, the problem doesn't occur anymore since the rebase (I was testing on the playground, which apparently is not up to date). I've updated the...
Agreed with @flimzy. I just want to add that `http.FileServer` [does not](https://github.com/golang/go/blob/f5608c20f7b88c20fa2cd70090d9917df63f5c8e/src/net/http/fs.go#L71-L96) set ``, and that's what `gopherjs serve` [uses](https://github.com/gopherjs/gopherjs/blob/db2cfff3878815d744fb4a4bd07cba0596eaf2a5/tool.go#L521). So to some degree, this is a bug you should...
Hmm, I would say this is a bug. GopherJS should ignore the tag if `*js.Object` isn't there.