Damien Mathieu

Only @open-telemetry/go-maintainers can merge PRs.

You should open a new issue for this, as this isn't the same issue since you're configuring a meter provider.

The call to RecordError probably needs to add the [WithStackTrace](https://pkg.go.dev/go.opentelemetry.io/otel/trace#WithStackTrace) option.

I'm not seeing the otelmux instrumentation calling `RecordError`: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/instrumentation/github.com/gorilla/mux/otelmux/mux.go So no, I'm not sure this is even otelmux related. A panic is mentioned in the description, but the only instrumentation...

Thank you. So, the `recover()` comes from the SDK itself, with the recover for `span.End()`. https://github.com/open-telemetry/opentelemetry-go/blob/fe9bab54b7a1852da0001b91ec37a417e96d8e7c/sdk/trace/span.go#L389 The solution here would be to close the span with a `trace.WithStackTrace()` option. That...

Urgh my bad, I did it on the wrong instrumentation 🤦 I won't be able to do another PR right away. Feel free to do so yourself.

There is no callback and such available for otelmux. So yes, a wrapping middleware is the way to go.

@alexgo84 did this answer your question? Can we close this issue?

The reason I didn't move the metrics to the reader is because we don't have access to the request in there, and it's therefore not trivial to add the metric...