Damien Mathieu

Results 259 comments of Damien Mathieu

This PR seems unfinished (the `GinFilter` isn't used, the `WithGinFilter` method accepts a `Filter`, not a `GinFilter` and there are no tests). I'm moving it to draft. Feel free to...

Did you run those tests? The filter exists, but isn't used anywhere. The code is also showing indentation issues that will fail linting. Note : I'm not sure this is...

Since this is changing the public API, I would like @hanyuancheung's opinion as code owner.

No. We need a second review.

cc @open-telemetry/go-approvers

You will need to add this module to the versions.yaml file, in the `excluded-modules` section. https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/versions.yaml#L91

There are still lint issues that need fixing.

This change only handles missing span in `end()` if `useSpans` is false. It seems like that could also happen with the use of sub spans as well. Also, I know...

@scorpionknifes After chatting with @pellared we think it would be easier for us to review this PR if you split it into smaller ones, like we did for zap and...