Diego Marcos
Diego Marcos
Leaning towards deprecation
Going back and forth with this: 1. Keeping old behavior is a big depart from mainstream THREE and code is complex to maintain forward. 2. Adapting to new model requires...
I multiplied the light defaults and values in examples by 3.14 https://github.com/aframevr/aframe/commit/8813d3d2818634ed4900409d99544b60587aa300 Also updated the environment component defaults and published a new version: 1.4.0 Any other outstanding 3rd party components...
@vincentfretin done. thanks 🫡
warn message is not super useful. Can we just detect we're in an iframe environment and show a more descriptive message?
> What error message would you consider useful? Not sure. Something that helps the dev understand what's going on and how to fix it. e.g: ``` You are running A-Frame...
left a comment in PR
What is the general context of this error? Are you still using the webvr code path?
Two thoughts here 1. Don't think we should check for gamePads if the scene is not in VR mode. I would add a guard here to check for `this.el.is('vr-mode')` here...
I merged a PR to remove WebVR support. This should no longer be an issue. Can you give master builds a try and let me know? https://cdn.jsdelivr.net/gh/aframevr/aframe@ce9fd2321c97daf01bf9f098ad8b625c1603bc63/dist/aframe-master.min.js Thanks!