Diego Marcos comments

Results 705 comments of


                                            Diego Marcos

device-orientation-permisson-ui: Don't emit "granted" event until permissions are actually granted.

It seems I don't fully understand promises 😄 If the `catch` function doesn't explicitly return a value the `then` function shouldn't run, right? It looks you're seeing something different and...

device-orientation-permisson-ui: Don't emit "granted" event until permissions are actually granted.

Thanks for the explanation!

Update list of performance improvement tips

Thanks! Re-wording is usually a matter of voice consistency and taste. Are there any additions you want to make or just reorganization?

Update list of performance improvement tips

Thanks. I think I like the simplicity of a single list of tips. Have you had any issues understanding or following the guidelines when building something?

Self Signed SSL error

weird. FWIW It's working for me on macOS (11.4). I haven't installed OpenSSL manually. Using whatever comes with the system. I don't remember having to install anything on Windows. What...

Self Signed SSL error

@vincentfretin Thanks so much for the info. At what level we should fix this? `pem`?

Self Signed SSL error

Thanks, no plans to replace build system for now. We can perhaps figure out a more surgical solution

Self Signed SSL error

I see there's a fix for `pem` but has not made it into a release. An option would be fork `pem` apply the fix and override the dependency (just learnt...

Update README.md

Thanks! I'm not a great writer. Just made a few comments. Some changes like `interfaces` read a bit different than I'm used to when talking about technical literature

Schema of single-property component with custom type requires default

Yeah default is necessary (probably we should elaborate on docs). After adding a default is it working for your use case?