Dmytro Maluka
Dmytro Maluka
@JoeKar what do you think about merging this?
> This will affect plugins currently using this method. Are they? I don't think we export it to lua. > Furthermore we shouldn't introduce any further `regexp.MustCompile()`'s, especially when user...
LGTM (I think I already approved this PR a while ago), except the following (echoing the discussion and outcome of #3812): 1. This? ```go --- a/cmd/micro/micro.go +++ b/cmd/micro/micro.go @@ -48,7...
> [luca020400@fd0365b](https://github.com/luca020400/micro/commit/fd0365bd67175a5b5b49203d75f593f17e19b505) Implements a very similar behavior to what I see on VIM that also take into account the order of commands passed via cmdline, shall I open a PR...
> I personally think it doesn't hurt to expose a function that creates a `Cursor` struct, which can be used in many other places, other scenarios that we might not...
> ```json > "*.cpp": { > "commenttype": "//%s" > } > ``` You probably meant the following? ```json "ft:c++": { "commenttype": "//%s" } ``` since with `"*.cpp"` the setting is...
1. I'm not sure we should show this noisy warning about `commenttype` vs `comment.type`. Wouldn't it be friendlier to silently support `commenttype` (especially since in https://github.com/zyedidia/micro/pull/3424/commits/f12b9410a2b8fc2906efb15c50479aa781ca9134 we already support it,...
 Press Tab -> what we expect is this, right?  Whereas with this PR we get this: 
> I think most of the scenario users would place their cursors on the same text occurrence to complete. So in those scenarios when they don't, we should at least...
> This raises the question of how does the user know which autocomplete is being filled for each multi-cursor if each of them can fill in a different word. Not...