Dmytro Maluka

Results 310 comments of Dmytro Maluka

Regarding problems with `JobStart()` on Windows, you could use `JobSpawn()` instead. (Although I don't disagree that making `JobStart()` work on Windows is a good idea.) Regarding this: > But even...

> I don't see how `onexit` can execute before `JobSpawn` returns, since the callback is executed in the main event loop. Ah, indeed... So, it is not `job` but `job.ProcessState`...

Ok, at least it wouldn't break compatibility with existing plugins (I thought it would, but I've just checked that it doesn't)... I'm wondering what is the use case, and how...

> local ex, ey = event:Position() You are assuming that the event is `EventMouse`? Did you actually try to use that? > I wan't to be able to know the...

Actually we can try just disabling its usage in micro (at least just as a test hack to see its actual impact on performance): ``` diff --git a/internal/screen/screen.go b/internal/screen/screen.go index...

Haven't had much time to look into it yet, sorry.

> ``` > // NewRegexpGroup creates a RegexpGroup from a string > func NewRegexpGroup(s string) (RegexpGroup, error) > ``` I'm worried that we are exposing such implementation details as padded...

Yes, it would be too smart.

> I don't want to claim that `RegexpGroup` is the ideal name, but it conveys the idea that several regexps are grouped together. That is exactly the kind of details...

> I haven't squashed the commits into one so far because this way it's easier to see what the intent of each change is. And that is not exactly helpful...