Dmytro Maluka
Dmytro Maluka
> Are you attached to the name `RegexpSearch`? I find that such a struct is not more related to searching than a single `Regexp`. Not exactly attached, I just have...
> > I haven't squashed the commits into one so far because this way it's easier to see what the intent of each change is. > > And that is...
> so that the review can be resumed Just in case, actually the main reason why the review (at least from my side) is currently in hold is just because...
> [...] And the reason why it works when starting micro is that in that case IsLoaded() confusingly returns true, since GlobalSettings[p.Name] has not been set yet. BTW @JoeKar you...
> What about `IsLoaded()`...do we change it with this PR? I haven't thought what to do with it. Anyway, we don't need to do anything with it in this PR.
Do we need to deprecate `indentchar`? I'd rather fix it to do something closer to what its documentation says, instead of what it does now (i.e. simply displays all tab...
> Repurposing a setting would be confusing since the user is not expecting it unless they read the documentation. It would be "backward compatible" in a sense: tabs would be...
> But if `tabchar` is "overriding" `indentchar` while `spacechar` isn't, wouldn't it make more sense to call it `indenttabchar`? Its primary role is to simply specify which character to use...
Simple question: do we want an option that allows the user to simply display all tabs (no matter at the beginning, at the end or in the middle of a...
> The reason I keep the `indent` name is to be consistent with previous name What's the point of being consistent with it if you are deprecating it? > That's...