Dan Kubb

Results 66 comments of Dan Kubb

@mbj I dunno. I can't think of any good reason a class with a memoized method shouldn't be subclassed. I'd kind of expect that it should just work. I'd rather...

@mbj what about something like the following change: ``` diff diff --git a/lib/memoizable/instance_methods.rb b/lib/memoizable/instance_methods.rb index 271387d..a46b78f 100644 --- a/lib/memoizable/instance_methods.rb +++ b/lib/memoizable/instance_methods.rb @@ -30,7 +30,9 @@ module Memoizable # # @api...

@mbj it should be above the fetch. Github is messing up the formatting though, so maybe it's hard to read.

@mbj yeah I was discussing this with @postmodern in #datamapper. It's my feeling that I would rather mutant nudge code towards having no redundant expressions. I mean, we could add...

@tjchambers Would it have helped if expressions that are just syntactic sugar were expanded first, then mutated: ``` ruby @foo ||= bar ``` Would become: ``` ruby @foo = @foo...

@mbj so it's more like: ``` ruby foo || (foo = bar) ```

What about using the junit XML format? yeah, I know it's XML (yuk), but it is supported by a few CI systems that we use at $work. You could always...

> Tagging as enhancement and not-on-authors-free-time. @mbj you could rename the `not-on-authors-free-time` tag as `needs-funding` to be more precise about what you require to work on the issue.

I think this is a reasonable mutation. You should only use `.?+` if there's a case where you need it to be non-greedy. You should have to provide a test...

> Is greedyness more primitive than non greedyness? I think so. I does require more syntax to enable non-greedy matching. I feel like if you're writing a regexp, and you're...