mutant icon indicating copy to clipboard operation
mutant copied to clipboard

Add contracts gem support

Open nepalez opened this issue 9 years ago • 8 comments

@mbj Possibly, you've already seen the contracts gem. What do you think of it? Are you planning to support it in future? (now using contracts makes method not recognizable by mutant).

nepalez avatar Aug 10 '15 12:08 nepalez

@nepalez I like the concept of the gem. But I do not use it in a commercial environment. So I cannot support this on my OSS time.

This gem "likely" needs a custom injector, just like we have one for adamantium memoizers. I'm happy for someone doing a PR (I can help with pointing to the implemnetation vector), or funds this: I'd merge the feature.

Tagging as enhancement and not-on-authors-free-time.

mbj avatar Aug 10 '15 12:08 mbj

@mbj thank you. Now I'm stuck to other projects, maybe in September I could make a try

nepalez avatar Aug 10 '15 13:08 nepalez

@nepalez For reference this is the current custom injection behavior for adamantium memoizers: https://github.com/mbj/mutant/blob/802e52338f5d6e2954a224e6f375a04c75527426/lib/mutant/subject/method/instance.rb#L30-L56

mbj avatar Aug 10 '15 13:08 mbj

Tagging as enhancement and not-on-authors-free-time.

@mbj you could rename the not-on-authors-free-time tag as needs-funding to be more precise about what you require to work on the issue.

dkubb avatar Aug 10 '15 14:08 dkubb

@dkubb It would appear it needs funding or a PR. @mbj please correct?

tjchambers avatar Aug 10 '15 14:08 tjchambers

@mbj you could rename the not-on-authors-free-time tag as needs-funding to be more precise about what you require to work on the issue.

Ack. I renamed to needs-funding-or-external-pr.

mbj avatar Aug 10 '15 15:08 mbj

+1, please add contract support for mutant. My project use gem contract on 100%? and I can use mutant-rspec for testing my test...

tit avatar Oct 26 '19 19:10 tit

@tit I'd be happy to review a PR. Assuming the author of such a hypothetical PR would sign my CLA.

Its unlikely authorship to happen on my time at this point.

mbj avatar Oct 26 '19 22:10 mbj