Dan Kubb

Results 66 comments of Dan Kubb

@mbj I wonder if a method_added hook could be used to warn when a memoized method is being overridden in the same class/module it's defined within? **Or** it could just...

@mbj what about using `method_added` to memoize `#to_s`, `#to_hash` and `#inspect` when they are added?

@mbj method_missing won't kick in because they'll inherit those methods from `Object`.

@orend I rebased this against master so it should be usable.

My latest commit adds a `#method_added` hook that will memoize a method when it is added. However, it loses the ability to memoize the built-in `#to_s` and `#inspect` methods. I...

@mbj sure, the first thing we could do show examples using `include` on separate lines, then it's more clear the ordering of things. We can have an "advanced" section showing...

@mbj wdyt about https://github.com/dkubb/adamantium/pull/25 ?

@snusnu can you work out a minimal test case that demonstrates the problem? This sounds like a bug and is not at all what was intended.

@snusnu this is a good point. I think the only reason I did that is that I wanted to apply a limit to the relation, since limiting an unordered relation...

> I'm not entirely sure i get your last point @snusnu my point was that lots of ORMs give people `#first` and `#last`, but once I had `#one`, `#max_one`, and...