Dima issues

Results 18 issues of


                                            Dima

Wrapped Napi-extracted functions into C++ `shared_ptr<>`-s for easier lifetime management.

Hi @gengjiawen, Was hoping for some feedback -- after experimenting with `node-addon-api` for a few days looks like I've managed to wrap the extracted functions into C++ objects that do...

We really don't recommend storing the Napi::Env. You can access it from promise_.Env()

Via @KevinEady, https://github.com/nodejs/node-addon-examples/pull/182#discussion_r656616979

WaitableAtomic's `Wait` and `WaitFor` return values unification.

Proposal: * `WaitFor` returns true or false, depending on whether the wait has succeeded or no. * `Wait` always returns `true`. * Also introduce `WaitAndReturn`, which returns `T` from the...

Replace `bool more` by an enum class in `BlockingWrite`.

Because `Connection& BlockingWrite(const char* s, bool more)` is called for `BlockingWrite(s, strlen(s))`, which clearly is not what the user intends.

Add some `PartialBlockingWrite` to the sockets wrapper library.

Add a unit test for `Variant<...>::Call(generic lambda)`.

`current::FileSystem::ReadFileByLines` doesn't throw when file does not exist?

Retire the Java-like `HTTPResponseCode.OK` syntax in favor of the C++ `HTTPResponseCode::OK` one?

Add and use top-level `TriggerSegmentationFault()` for critical invariant checks?

Hi @mzhurovich, @grixa, @nyospe, I'm finding my code to have a few `CURRENT_THROW( ... _internal error_ ...)` exceptions, which, during debugging, I often end up forcefully making into SEGFAULT-s to...

The `::dlopen()` nuanced magic isolated and tested!

@mzhurovich pls test on a Mac.