Dima Kogan

Hello. This is very low priority for me since pinhole rectification is strictly worse than latlon rectification in every way: https://mrcal.secretsauce.net/stereo.html If you need this, you should implement it! It...

Yep. The python function `mrcal.rectified_system()` is the outer logic, and it makes sure to call the Python code when using pinhole models: https://github.com/dkogan/mrcal/blob/71c89c4e9f268a0f4fb950325e7d551986a281ec/mrcal/stereo.py#L422 So you're remove that `if` statement entirely....

akonneker ***@***.***> writes: > So I have it implemented, and test-stereo.py and > test-rectification-maps.py are now passing. Cool! > The primary issue is how to replace the root-finding provided by...

Hi. Are you still trying to do this? Do you need help?

I'm not following the full, complex sequence, but on a high-level, it seems like it should mostly work. If you are able, I would simplify: do you really need the...

If you have a low-res camera, bring the object it's looking at closer to make things appear bigger. The way you're doing it won't make anything fail catastrophically, but your...

I don't know what I'm supposed to do with those images. But don't show them to me; this is for your own sanity checking, since you have a logic bug...

Hi. Sorry, I don't have the cycles right now to really think about this. But it sounds like you're on the right track, and hopefully will figure it out. Good...

From a high-level, that's right: you `mrcal.unproject()` to get directions, and scale them up with the ranges. If it doesn't work, tell me.

Hello. Would it be possible to share the data as well, so that I could reproduce the issue here? Would make it unnecessary to guess about what's going on