Damien Miller comments

Results 85 comments of


                                            Damien Miller

Remove unused <netinet/in_systm.h> and <resolv.h> inclusions.

resolv.h is needed for base64 functions on some platforms ``` hostfile.c:97:8: error: call to undeclared function '__b64_pton'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] ret =...

cipher-chachapoly: use OpenSSL's implementation of Poly1305

I've discussed this with one of the LibreSSL developers and I think we'll probably prefer to use the BoringSSL poly1305 API (which LibreSSL will also adopt), and add a shim...

Fix regular users expired password reset issue

On which platform did you experience this? AFAIK the existing code is correct for some of the three platforms where PASSWD_NEEDS_USERNAME is enabled (Solaris, UnixWare, OpenServer)

Fix regular users expired password reset issue

I'm more confused now - no Linux variant sets PASSWD_NEEDS_USERNAME in configure, are you setting it manually? If so, why?

docs: LocalForward and RemoteForward can act on unix-domain sockets

Merged in fe4305c37ffe535 - thanks

set tcp_nodelay

We already unconditionally set nodelay fairly early on the connection socket (e.g. [here](https://github.com/openssh/openssh-portable/blob/0fb1f3c9955d78fb0959842202b9ecfc36e37486/packet.c#L2238-L2240)). Is there some path where this isn't happening?

Specify the default for MaxStartups later in the text

Thanks - this has been merged as 7e68771f3cad61ec67303607afb3b85639288b29

Build openssh on macOS not using libutil

What benefit does this yield?

Add support for match patterns in LocalPort conditional blocks

Looks reasonable to me. @daztucker any objections to my committing?

Log session length in disconnection message

If you turn on `LogLevel=verbose` this information is already available on the client ``` Connection to blah closed. Transferred: sent 4228, received 4588 bytes, in 2.0 seconds Bytes per second:...