Damien Miller
Damien Miller
This is good work, but the portable OpenSSH repository is just a mirror of ssh-copy-id from its upstream http://git.hands.com. I recommend sending your changes to the maintainer of ssh-copy-id ([email protected])...
You might be interested in https://github.com/djmdjm/openssh-wip/pull/5 that does something similar, but doesn't require ssh's active inspection of agent requests. I wanted to avoid this because it would make ssh a...
Thanks - I hadn't realised that the pam_ssh_agent_auth.so module had bitrotted so badly. As far as including this in the portable OpenSSH distribution, we could host it under contrib/ but...
Let me take a look at the refactoring - I think I can do something that gets rid of `struct ssh` as well as `ServerOptions`
I added a comment on the change, but this isn't correct. We already have `HostkeyAlgorithms` to control which signature algorithms are used for hostkey negotiation. Your patch instead adds filtering...
The server side of this landed in openssh-7.9, but we didn't commit the client side. If you have a use-case for that then we could consider it.
I have merged most of this, but added a couple of comments to the remaining part
I just merged something equivalent to the `windows://hello` change in cd06a76b7
I think that just leaves the `Defer FIDO token PIN prompt when signing the credentials` change to go; please see my last comments on that.
I've pushed a slightly-tweaked version of that last commit as f9648090, so I think that is everything. Please take a look and close the PR if you're happy