Damien Miller
Damien Miller
Closing this for lack of response. It looks like user configuration is the problem here.
This isn't sufficient, as TERM has special handling in the ssh session protocol (see https://datatracker.ietf.org/doc/html/rfc4254#section-6.2) that doesn't exist for COLORTERM. Fortunately you can get COLORTERM sent without any code changes...
This looks reasonable (modulo tabs vs spaces formatting), but I'm really not a GSSAPI or KRB5 expert. I think the best way to proceed is to find someone who knows...
I don't see how this could work, because the code later does this: ```c if (signer == NULL) { /* Not using agent - try to load private key */...
I've merged this because the previous code was clearly wrong, but Darren's question is still standing: > Back to the PR: which platform(s) and/or configure options did you observe the...
How widely used are these init systems? This feature might be a bit too niche... One problem you're likely to run into is the unconditional `closefrom()` in sshd.c:main() that will...
I'll look at getting this fixed upstream, but it's amusing the analyser missed another dereference just a few lines later: https://github.com/openssh/openssh-portable/pull/476/commits/055543846e1a76b6addbd15d6c0882a08bfec223#diff-32a975c1ea4e4ce98e3d001c8be80d498926d26459768d97fe241173e73ea0a5R289
key=NULL is impossible here as sshkey_froms() won't return a NULL key. I'll look at removing the unnecessary key==NULL checks instead
Is this for AddKeysToAgent?
I don't understand - nothing in OpenSSH logs this string