Gildas Garcia

Results 188 comments of Gildas Garcia

Ok, phantom is good enough anyway and easier to use for CI. Thanks a lot for this package btw :) Really great work. Can't wait for the parallel version!

@Sanjo nope, this makes chrome fail to start ``` events.js:72 throw er; // Unhandled 'error' event ^ RuntimeError: RuntimeError (UnknownError:13) An unknown server-side error occurred while processing the command. Problem:...

Finally found a way to use ChromeDrivrer and not be annoyed with multiple Google Chrome windows openning and stealing focus: I use `devilspie` and have 2 worspaces set in my...

Thanks but I'd rather have prettier handle the formatting itself by adding `eslint-prettier-config` and `eslint-prettier-plugin`

> @djhi you mean I should check if `preferenceKey` strictly equal to `undefined` right? I mean that to have it work like it did before, we should have a default...

Sorry for the noise. `query-string` actually does more that `URLSearchParams` and we decided to keep it. Can you rebase or merge the latest `next` branch? Thanks!

> I think we should add the typescheck of the simple example to the typecheck CI step Added

You have to wrap your component in a `forwardRef`: ```jsx const CustomAlertComponent = React.forwardRef((props, ref) => { return ( This is a custom error ); }); ``` This is required...

Hi! Can I do anything to solve the CI issue?

That would indeed be better and avoid an extra dependency! Thanks for the suggestion.