Allow <Title /> to be nonConfigurable
This addresses https://github.com/marmelab/react-admin/issues/8776
Testing:
Added storybook entry
@fzaninotto @adguernier I believe this is ready for review again. Thanks!
Reviewed. Thanks for your work @markyao6275 :+1:
Thanks for the comments @adguernier! Should be ready for another review :)
Aside from the last two comments, LGTM. Thanks for your work :muscle:
@djhi you mean I should check if preferenceKey strictly equal to undefined right?
Anyway I tried to address your feedback in the most recent commit so please let me know if that's what you had in mind.
@djhi you mean I should check if
preferenceKeystrictly equal toundefinedright?
I mean that to have it work like it did before, we should have a default preferenceKey set and users have to explicitly disable it by setting it to false. Hence, you should check if it is strictly equal to false to render the non configurable version. This is coherent with other part of react-admin.
@djhi just acted on your feedback
For
I mean that to have it work like it did before, we should have a default preferenceKey
I just passed through the preferenceKey from <Title /> to <PageTitleConfigurable /> so that I don't have to specify the default ${pathname}.title in more than one place.
Let me know if there's anything else you'd like me to change.
@djhi friendly bump here
@djhi addressed, thanks!
@djhi friendly bump here
@slax57 addressed your comments, thanks!