Gildas Garcia

Results 188 comments of Gildas Garcia

Closed by [#10279](https://github.com/marmelab/react-admin/pull/10279)

It's actually not related to the call to `useChoicesContext`. It's because you currently have to memoize the values you provide to props accepting a function or an element. See https://stackblitz.com/edit/github-guchrk-vwc9uq?file=src%2Fcomments%2FCommentEdit.tsx...

> There seems to be some other issues that are happening due to this bug. I was able to get it to repro in codesandbox here: https://codesandbox.io/p/sandbox/hw3khq > > Note...

I can't see a way to test this except e2e. Not sure if we can simulate network loss with cypress though

> I think the change of the ListContext shape affects more components; e.g. useListContextWithProps. That's the only one left AFAIK

> When doing an optimistic offline mutation, the loader in the app bar keeps spinning forever even tough the optimistic update is already applied. Is it a good UI? Instead,...

I agree with @fzaninotto. Thanks for the PR anyway :)

Hi @Tomas025, of course! Be aware that you'll need to: - target the `next` branch as this is a new feature - add a story for this new prop in...