divo12
divo12
@vfdev-5 In https://github.com/pytorch/ignite/blob/3a286b1d13a4a0476b3ee8e8046f16465818c9f6/tests/ignite/metrics/gan/test_fid.py#L158 https://github.com/pytorch/ignite/blob/3a286b1d13a4a0476b3ee8e8046f16465818c9f6/tests/ignite/metrics/gan/test_inception_score.py#L68 the _test function could be improved in the _test_distrib_integration function I could make changes all the places where this _test_distrib_integration function is used Draft code: ```...
@vfdev-5 check this one https://github.com/pytorch/ignite/blob/3a286b1d13a4a0476b3ee8e8046f16465818c9f6/tests/ignite/handlers/test_checkpoint.py#L99 draft code: ``` def test_checkpoint_default(): model = DummyModel() optimizer = torch.optim.SGD(model.parameters(), lr=0.1) @pytest.mark.parametrize("to_save,obj,name", [ ({"model": model},model.state_dict(),"model"), ({"model": model, "optimizer": optimizer},{"model": model.state_dict(), "optimizer": optimizer.state_dict()},"checkpoint"), ]) def...
Umm i could shift this part of my code above 'test_checkpoint_default' and parametrize 'test_checkpoint_default' with the parameters of '_test' and remove '_test' ``` model = DummyModel() optimizer = torch.optim.SGD(model.parameters(), lr=0.1)...
@vfdev-5 I have sent a draft PR.Please review it
I'll be working on 16.5 Personalized Ranking for Recommender Systems
can you merge this PR? Since the dataset loading functions are called in every other section of the chapter, its tough for us to develop the subsequent sections
I wish to contribute code for Recommender systems in Pytorch.May I contribute?
@AnirudhDagar @Ishan-Kumar2 @Garg-Doppler can you review this PR? I have made changes according to the new YAML format
@Ishan-Kumar2 done the required changes. I'll make a separate PR for #18