d2l-en
d2l-en copied to clipboard
d2l-ai
[PyTorch] Add The MovieLens Dataset
Description of changes:
Add PyTorch code to 16.2. The MovieLens Dataset (movielens.md).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Job d2l-en/PR-2030/1 is complete. Check the results at http://preview.d2l.ai/d2l-en/PR-2030/
Job d2l-en/PR-2030/2 is complete. Check the results at http://preview.d2l.ai/d2l-en/PR-2030/
Job d2l-en/PR-2030/2 is complete. Check the results at http://preview.d2l.ai/d2l-en/PR-2030/
Job d2l-en/PR-2030/4 is complete. Check the results at http://preview.d2l.ai/d2l-en/PR-2030/
can you merge this PR? Since the dataset loading functions are called in every other section of the chapter, its tough for us to develop the subsequent sections
Job d2l-en/PR-2030/6 is complete. Check the results at http://preview.d2l.ai/d2l-en/PR-2030/
Job d2l-en/PR-2030/7 is complete. Check the results at http://preview.d2l.ai/d2l-en/PR-2030/
Job d2l-en/PR-2030/8 is complete. Check the results at http://preview.d2l.ai/d2l-en/PR-2030/
Job d2l-en/PR-2030/9 is complete. Check the results at http://preview.d2l.ai/d2l-en/PR-2030/
@KuanHaoHuang could you please rebase this PR to accommodate latest changes from master? That would also trigger the github actions for the same. Thanks!
Hi @KuanHaoHuang, it looks like the merge was not made correctly. Request you to please fix that.
Hi @KuanHaoHuang, it looks like the merge was not made correctly. Request you to please fix that.
Thanks for the reminder, @AnirudhDagar. I made a rookie mistake and just fixed it.
However, even though I rebased to resolve the problem in the d761547 commit, the CI job preview http://preview.d2l.ai/d2l-en/PR-2030/d761547 seems to (weirdly) render the problematic bc7e752, instead of the d761547 commit as shown in the url of the preview.
Is there anything I should do to solve the preview problem to make your review easier? If so, please let me know, thanks!
Job PR-2030-d761547 is done. Check the results at http://preview.d2l.ai/d2l-en/PR-2030/d761547
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @KuanHaoHuang thanks for the update, yes that's not your fault. I've made another merge from master to include the recent changes. CI should be happy now!
Job PR-2030-d8d5c0e is done. Check the results at http://preview.d2l.ai/d2l-en/PR-2030/d8d5c0e
Hi @AnirudhDagar, Thanks for merging from the master
Even though the commits all look sane, the movielens pages of d8d5c0e preview are not aligned with the d8d5c0e commits and show catastrophically weird results.
Is it possible that we fix the preview and make this code review process smoother?
Yes, it seems to be a issue with the cache not being cleared out. I'll fix that and rerun the PR.
Job PR-2030-d8d5c0e is done. Check the results at http://preview.d2l.ai/d2l-en/PR-2030/d8d5c0e
@KuanHaoHuang don't worry about the preview atm, I'll review the PR. Meanwhile if you are interested you can start working on the next sections for recsys chapter.
@KuanHaoHuang don't worry about the preview atm, I'll review the PR. Meanwhile if you are interested you can start working on the next sections for recsys chapter.
Thanks for the heads-up, @AnirudhDagar.
Sure, I'll work on other sections in this chapter. And I won't send another PR before the review of this movielens section finish.