dirkmc

My vote is for creating a new channel - the existing channel is already linked to from a few places, and there are already a bunch of people in it...

For each CID that is wanted by any session, we keep a "block presence" table of which peers have sent us a HAVE or DONT_HAVE - CID1 - peer A:...

> When we cancel a want for a block (without canceling the rest of the session). That is, we can cancel a mySession.GetBlock It looks like in that case we...

Filed a bug at https://github.com/ipfs/go-bitswap/issues/253

> Do we remove peers from sessions when they disconnect? Yes, the PeerManager [tells the Session](https://github.com/ipfs/go-bitswap/blob/master/internal/peermanager/peermanager.go#L123) when a peer disconnects > 3. The other peer asks us for a block...

Any reason not to merge? (I see it's a draft PR)

Internally we use a pubsub library that creates a channel for incoming blocks. Bitswap sends received blocks on this channel and the "getter" reads from the channel (line 111). The...

This proposal LGTM - I'm not sure I understand what "the same buffer" means in this context - do you mean the size of the output channel buffer is the...

Currently in Bitswap - `Session.GetBlocks()` [adds wants to a queue](https://github.com/ipfs/go-bitswap/blob/master/session/session.go#L328) and returns immediately - When blocks arrive from peers - we store incoming blocks in [an internal channel](https://github.com/ipfs/go-bitswap/blob/8904e045491195f45e7b7b59ead70de017e2234e/notifications/notifications.go#L67 ) whose...

@aschmahmann and I talked it over and he suggested that there may be some scenarios in which back-pressure would be useful. For example if an app uses Bitswap to download...