dirkmc
dirkmc
Sorry I didn't think of the case in which unrelated queries are executed in parallel to queries which must happen inside the transaction. I took a look at implementing the...
It's also worth mentioning that the problem of concurrent, unrelated queries occurring within the transaction already exists in this module if connection pooling is disabled, which kind of defeats the...
I found a solution to the problem which is similar to what @SPARTAN563 and @dxg discussed above. I create a connection pool, and take a single connection from it (let's...
Some documentation here: https://github.com/ipfs/go-bitswap/issues/165
I think this will change the definition of a duplicate blocks from "a block we receive that is already in the blockstore" to "a block that was not wanted by...
Thanks for doing this work - in retrospect I should have written something like this at the beginning of the refactor :)
go-bitswap does not provide events, however it does provide statistics on request: https://github.com/ipfs/go-bitswap/blob/master/stat.go#L10
Hi David, thanks for the heads up, I'm interested to hear more about your work. We're actively making improvements, and in fact there is a big change coming - we're...
@dgrisham just to clarify, what would you like review feedback on? Just the tests? Or do you have a set of changes in a PR that you'd like reviewed?
Overall the tests look good to me. I'd suggest that rather than using random numbers of peers and block sizes, you select a few that test important values (eg boundaries)...