go-bitswap icon indicating copy to clipboard operation
go-bitswap copied to clipboard

feat: refactor message receiving code

Open Stebalien opened this issue 5 years ago • 3 comments

The primary motivation for this was to only account for wanted blocks in the engine.

This change also untangles some code, fixes some todos, and avoids reusing receiveBlocksFrom for processing local blocks.

Stebalien avatar Jun 05 '20 23:06 Stebalien

Any reason not to merge? (I see it's a draft PR)

dirkmc avatar Jun 08 '20 13:06 dirkmc

Any reason not to merge? (I see it's a draft PR)

I wanted to get in a quick fix first for the release. I left it as a draft due to that last question.

Stebalien avatar Jun 08 '20 18:06 Stebalien

Let's wait until we get #413 fixed before merging this (so we don't have to fork a patch release branch).

Stebalien avatar Jun 10 '20 16:06 Stebalien

This repository has been moved to https://github.com/ipfs/go-libipfs. There is not an easy way to transfer PRs, so if you would like to continue with this PR then please re-open it in the new repository and link to this PR.

Jorropo avatar Jan 27 '23 22:01 Jorropo