Mathieu Pillard

Results 384 comments of Mathieu Pillard

To investigate: can we do what we are doing now but somehow avoid duplicating emails to the owner(s) (still need to send emails to each reporter if necessary) and activities...

Yes, I know, my sentence had a "and activities" at the end to account for that.

I think the path forward is: - In the `process_action()` method for the various `ContentAction` classes, don't record a new `ActivityLog` if we didn't do anything (i.e. the action has...

Yes, that was my question at the end. We could edit the activity details and relink any missing `ContentDecision` once they have all been created.

STR: - Report an add-on for policy violation on the website (leave your email as the reporter) - In Cinder, escalate that to reviewers - Report an add-on for policy...

> What I didn't see on -dev is reject and disable actions registered in reviewactionreasonlog admin. That's available now on -stage so it appears to be a regression. Is that...

Is that something "regular" reviewers need ? Because users with access to the admin tools already some of that functionality... I'm not sure it's worth spending time re-implementing all that...

As noted, by default browsers might not always show the scrollbar even with `overflow: scroll`. This is an old problem, but fortunately there is a clever hack that should work...

Yes, good catch. I removed the `max-width` for consistency thinking the rules on the other class would be enough, but it's not...

Yes, I have a fix (hopefully) that I just merged in https://github.com/mozilla/addons-server/commit/fadb56aec569be27300109977c8e7866f84bc1e8 ; it should land on dev shortly.