addons icon indicating copy to clipboard operation
addons copied to clipboard

[Bug]: On a disabled by Firefox add-on the reason is not shown

Open ialecse opened this issue 9 months ago • 2 comments

What happened?

A listed add-on shows as it was force disabled by Firefox, but it does not show the reason why it was disabled.

What did you expect to happen?

The reason for force disabling should be shown at least in the history.

Is there an existing issue for this?

  • [x] I have searched the existing issues

┆Issue is synchronized with this Jira Task

ialecse avatar Mar 28 '25 08:03 ialecse

Shown where, to whom ? Reviewers ? Developers ? Users ?

diox avatar Mar 28 '25 09:03 diox

It should be shown in the review page, once in the Add-on important changes history section, where the action is logged. In addition it should be shown in the add-on's version's log, where the action happened. This normally happens whenever a reviewer force disables an add-on, but it seems it did not happened when the Firefox account did it.

ialecse avatar Mar 28 '25 10:03 ialecse

This is because moderators in Cinder don't necessarily use the notes section, though they are choosing a policy. We don't show the policy/review reason when displaying the activity in reviewer tools, we should.

diox avatar Apr 01 '25 13:04 diox

It should be pretty easy to expose the policy text after https://github.com/mozilla/addons/issues/15506 (which will store the policy text in the activity log)

eviljeff avatar Apr 01 '25 13:04 eviljeff

Lgtm, I've tested on -dev with:

Extensions: https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/637778 https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/637780 https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/637781

A theme: https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/637653

ioanarusiczki avatar May 12 '25 13:05 ioanarusiczki