Daniel Ingraham

Results 28 comments of Daniel Ingraham

I can actually fix this by commenting out [this line](https://github.com/jonniedie/ComponentArrays.jl/blob/fac804d49f63f9edbc057e7da06b854acf9a3792/src/axis.jl#L69), which creates a `FlatAxis` when constructing a `ShapedAxis` for a 1D array. That appears to preserve the necessary shape information...

OK, I attempted to fix this issue by introducing a `Shaped1DAxis` type in this PR: https://github.com/jonniedie/ComponentArrays.jl/pull/249. It fixes the issue described here, but breaks some relatively minor things (IMHO). The...

Now almost everything works with https://github.com/jonniedie/ComponentArrays.jl/pull/249. The things that are broken: * Creating a `ComponentArray` with an empty `NamedTuple` is not identical to creating one with an empty `Array`, like...

Managed to fix the test for indexing a `ComponentIndex` with multiple symbols. Now the only broken test in https://github.com/jonniedie/ComponentArrays.jl/pull/249 is the "empty `NamedTuple` vs empty `Array` one, which is relatively...

See discussion in this issue: https://github.com/jonniedie/ComponentArrays.jl/issues/248

@jonniedie polite ping re: this PR.

@jonniedie Another polite ping re: this PR. :-) It's ready to go from my perspective.

@jonniedie Another polite ping re: this PR. :-)

Thanks for pinging me on this discussion. Yes, I'm a big fan of `ComponentMatrix` and ComponentArrays.jl in general. I would be sad if we lost `ComponentMatrix`, but it does everything...

A counter-proposal: instead of getting rid of `ComponentMatrix` and higher-dimensional `ComponentArray`s, what about restricting the functionality of `ComponentArray`? The idea would be to treat * indexing with symbols * `getproperty`...