ComponentArrays.jl icon indicating copy to clipboard operation
ComponentArrays.jl copied to clipboard

Mat index bug

Open dingraha opened this issue 1 year ago • 6 comments

dingraha avatar Mar 05 '24 20:03 dingraha

See discussion in this issue: https://github.com/jonniedie/ComponentArrays.jl/issues/248

dingraha avatar Mar 06 '24 16:03 dingraha

@jonniedie polite ping re: this PR.

dingraha avatar Mar 19 '24 12:03 dingraha

@jonniedie Another polite ping re: this PR. :-) It's ready to go from my perspective.

dingraha avatar Mar 29 '24 18:03 dingraha

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.07%. Comparing base (fac804d) to head (b43853b). Report is 2 commits behind head on main.

Files Patch % Lines
src/axis.jl 88.88% 1 Missing :warning:
src/componentindex.jl 50.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
+ Coverage   73.88%   74.07%   +0.18%     
==========================================
  Files          23       25       +2     
  Lines         743      787      +44     
==========================================
+ Hits          549      583      +34     
- Misses        194      204      +10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 07 '24 01:04 codecov-commenter

@jonniedie Another polite ping re: this PR. :-)

dingraha avatar Apr 18 '24 15:04 dingraha