eightshift-frontend-libs icon indicating copy to clipboard operation
eightshift-frontend-libs copied to clipboard

Published 20 hours ago • verified publisher icon infinum

Update bem menu

Open dingo-d opened this issue 4 years ago • 1 comments

Still needs to be tested and tweaked.

Added a JS that will make it accessible (tabbable), modified the structure to conform to the BEM structure, and work with the updated BEM menu walker.

dingo-d avatar Feb 20 '21 16:02 dingo-d

I'll merge this when I test this on an example project. So far the build process is broken so I'm blocked on this.

Ref. https://github.com/infinum/eightshift-libs/issues/144

dingo-d avatar Feb 22 '21 10:02 dingo-d

Closing this, as we're not using WP menus anymore, there's a new "Site navigation" and "Site footer" block to cover basic functionality.

goranalkovic-infinum avatar Oct 17 '23 12:10 goranalkovic-infinum

Btw the only 'issue' with the walker in the libs was not updating the arguments (removing optional arg at the end iirc) to match the fix in the WP Core.

https://github.com/infinum/eightshift-libs/pull/373/files#diff-f7770bbdec7f1329b3dfd2de07b166174ff20669cb388f09b795e60f60ed38d7

The thing you added with site navigation and footer is messing things up for multilingual sites.

Why didn't you start using FSE instead if you wanted to have reusable footers and headers?

dingo-d avatar Oct 17 '23 13:10 dingo-d