David Hotham

Results 593 comments of David Hotham

nothing I can do with it, I'm just a humble contributor

on further investigating PEP440 I no longer think that the unfixed interpretation is reasonable > "The exclusive ordered comparison

good spot. There's more than one way to skin a cat, but I'll re-suggest https://github.com/python-poetry/poetry/issues/6519#issuecomment-1247339637 > suggest that next_breaking() wants to start by going `stable = self.stable` and then consider...

I appreciate all the tests! If anything I'd say you've gone a little over the top here, but I shouldn't discourage tests! I have some questions - why move the...

oh also I now notice that you've changed the implementation of stable() so that it sometimes returns a postrelease. (I was blind to this before on account of it moving...

We're talking past each other. I've no problem with `stable()` being fixed to preserve precision. I am (i) asking why it moved to a different class and (ii) suggesting a...

poetry-core's `Version` does not always have a precision of three. So moving this code out of the `Version` class for that reason is unnecessary. I propose that the entire diff...

There's lots of crud in poetry-core that it's desirable to remove (I have similar queued up that I'll submit when things quieten down / I have a large enough collection)....

Added a couple more removals to this MR, probably might as well discuss / make a decision for them all in the same place - `EmptyConstraint.matches()` should be uncontroversial, who...

Actually the export plugin is an example of a project that relies on the python_marker, but only for the root package. I'm pretty neutral about whether to leave it on...