poetry-core
poetry-core copied to clipboard
Explicitly print gitignored
Resolves: python-poetry/poetry#6443
- [ ] Added tests for changed code.
- [ ] Updated documentation for changed code.
Didn't add tests as it's just a matter of calling the logger. I also fixed a typo, changing explicitely_<excluded | included>
to explicitly_<excluded | included>
.
PR for https://github.com/python-poetry/poetry/issues/6443
you seem not to have logged the vcs_ignored_files - which are the ones https://github.com/python-poetry/poetry/issues/6443 actually complains about being unlogged
perhaps it would be better just to log the final answer from ignored
?
Thanks for the comment! Fixed. Curious under what conditions a file will be explicitly_excluded? l see that it's an instance field in ProjectPackage
, but I'm wondering what that looks like when actually using Poetry.
Thanks for the comment! Fixed. Curious under what conditions a file will be explicitly_excluded? l see that it's an instance field in
ProjectPackage
, but I'm wondering what that looks like when actually using Poetry.
There is an exclude =
field in pyproject.toml
to explicitly exclude files.
Curious how the Poetry milestone system works.
Does being added to the milestone mean that this is good to go, or is more work required?
this currently has merge conflicts, it's certainly not good to go before they are resolved
Sorry, missed the merge conflicts - just resolved them @dimbleby
@dimbleby just bumping this. No rush.
nothing I can do with it, I'm just a humble contributor
@neersighted bumping this
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
1.0% Duplication