poetry-core icon indicating copy to clipboard operation
poetry-core copied to clipboard

Explicitly print gitignored

Open evanrittenhouse opened this issue 1 year ago • 8 comments

Resolves: python-poetry/poetry#6443

  • [ ] Added tests for changed code.
  • [ ] Updated documentation for changed code.

Didn't add tests as it's just a matter of calling the logger. I also fixed a typo, changing explicitely_<excluded | included> to explicitly_<excluded | included>.

PR for https://github.com/python-poetry/poetry/issues/6443

evanrittenhouse avatar Sep 14 '22 20:09 evanrittenhouse

you seem not to have logged the vcs_ignored_files - which are the ones https://github.com/python-poetry/poetry/issues/6443 actually complains about being unlogged

perhaps it would be better just to log the final answer from ignored?

dimbleby avatar Sep 14 '22 21:09 dimbleby

Thanks for the comment! Fixed. Curious under what conditions a file will be explicitly_excluded? l see that it's an instance field in ProjectPackage, but I'm wondering what that looks like when actually using Poetry.

evanrittenhouse avatar Sep 14 '22 21:09 evanrittenhouse

Thanks for the comment! Fixed. Curious under what conditions a file will be explicitly_excluded? l see that it's an instance field in ProjectPackage, but I'm wondering what that looks like when actually using Poetry.

There is an exclude = field in pyproject.toml to explicitly exclude files.

neersighted avatar Sep 14 '22 23:09 neersighted

Curious how the Poetry milestone system works.

evanrittenhouse avatar Sep 18 '22 12:09 evanrittenhouse

Does being added to the milestone mean that this is good to go, or is more work required?

evanrittenhouse avatar Sep 18 '22 12:09 evanrittenhouse

this currently has merge conflicts, it's certainly not good to go before they are resolved

dimbleby avatar Sep 18 '22 13:09 dimbleby

Sorry, missed the merge conflicts - just resolved them @dimbleby

evanrittenhouse avatar Sep 18 '22 13:09 evanrittenhouse

@dimbleby just bumping this. No rush.

evanrittenhouse avatar Sep 29 '22 22:09 evanrittenhouse

nothing I can do with it, I'm just a humble contributor

dimbleby avatar Sep 30 '22 07:09 dimbleby

@neersighted bumping this

evanrittenhouse avatar Oct 01 '22 15:10 evanrittenhouse

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

sonarcloud[bot] avatar Oct 01 '22 15:10 sonarcloud[bot]