David Hotham

Results 593 comments of David Hotham

Yes, this would be breaking for users who: - are using a password that contains a backslash - have understood that configuring their Helm chart to use this password does...

I've submitted #630. I understand that this project is in maintenance mode so perhaps you are not likely to release this fix; but if you are able to publish a...

Thanks! I would think this is breaking only for folk who are relying on bugged behaviour - which normally wouldn't "count" as breaking, though it certainly wants calling out in...

Ran into another example that's broken by the bad quoting today: a password that itself contains a quotation mark produces faulty configuration.

I'm not going to make it to that meeting, sorry. We can update our workaround to do a more thorough job of pre-escaping the password, so that when the helm...

Much of this appears to be in vendored code, I don't expect this project wants to be making changes there. Perhaps you could take these changes upstream, if you feel...

Most of the changes currently in this MR are in third party code, vendored into this repository. It would make more sense to offer those changes to the original projects....

The changes in e932cdab157189088b357849f080850d5e457feb make things worse, not better. The type signatures were correct before, and scattering `Any` all over the place simply makes them less useful. Edit: I see...

I don't understand your point. That's exactly the current implementation on master, and it typechecks just fine without an `Any` annotation?

As I say, I think that mypy has a special case for `NotImplemented` and the refactoring has disturbed the balance. Suggest just put that code back as it was and...