db

Results 19 comments of db

@sameergoyal reached out to author who confirmed they still plan on completing this PR

@nkev I would like to clarify, there is no plans for the maintainers to actively create this feature, not that we would not accept this feature as a contribution. We...

It is incorrect to say that `fromEnv` wouldn't work in the browser environment, it is common for environment variables to be placed into `process.env` via build processes. The use case...

> The existing error clearly mentions fromEnv is not exported for browser environment. The users shouldn't try to import credential provider not available in their environment. Which is not documented,...

If the decision is made not to include these, I think it should be considered to have the credential providers throw errors at run time which point towards the documentation...

also make sure `yarn run test` passes : https://github.com/awslabs/synchro-charts/runs/7548619663?check_suite_focus=true

make sure to have commits squashed, to have a 1 to 1 mapping of PR to commits

PR doesn't build, on build: ``` [ ERROR ] TypeScript: ./src/components/charts/common/types.ts:9:3 Module '"../../../utils/dataTypes"' has no exported member 'DialSizeConfig'. L8: DataStreamId, L9: DialSizeConfig, L10: MessageOverrides, ``` Please make sure the branch...

We've added some coding guidelines at https://github.com/awslabs/iot-app-kit/blob/main/docs/CodingGuidelines.md which should help on setting expectations and general guidelines. please take a look

the build fails because the generated typescript type definitions are not present in the commit: ``` Run yarn build yarn run v1.22.19 $ lerna run build --stream lerna notice cli...