diagram-maker icon indicating copy to clipboard operation
diagram-maker copied to clipboard

Add capability for multiple custom connectors to be connected to edges

Open ktsao565 opened this issue 2 years ago • 2 comments

This is an initial PR to get some eyes on the overall approach. Additional unit tests and integ tests are in progress, but I wanted to initiate the initial review on the high level changes.

Issue #, if available: https://github.com/awslabs/diagram-maker/issues/67

Description of changes:

  • Add capability for edges to connect to individual custom connectors
  • Allow consumer to configure the position of custom connectors

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ktsao565 avatar Mar 16 '22 08:03 ktsao565

Just checking if there are plans to address the comments and merge this one in?

sameergoyal avatar Apr 12 '22 10:04 sameergoyal

@sameergoyal reached out to author who confirmed they still plan on completing this PR

diehbria avatar Sep 19 '22 17:09 diehbria

any updates?

matr369 avatar Apr 26 '23 11:04 matr369

@matr369 Change has been merged.

tracy-french avatar Apr 26 '23 19:04 tracy-french