UI: Add assertion to `FormField` for @attr.name and @model args
Description
Add assertion to force presence of @attr.name key and @model arg
TODO only if you're a HashiCorp employee
- [ ] Backport Labels: If this fix needs to be backported, use the appropriate
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.- [ ] LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
- [ ] ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature of a public function, even if that change is in a CE file, double check that applying the patch for this PR to the ENT repo and running tests doesn't break any tests. Sometimes ENT only tests rely on public functions in CE files.
- [ ] Jira: If this change has an associated Jira, it's referenced either in the PR description, commit message, or branch name.
- [ ] RFC: If this change has an associated RFC, please link it in the description.
- [ ] ENT PR: If this change has an associated ENT PR, please link it in the description. Also, make sure the changelog is in this PR, not in your ENT PR.
CI Results: All Go tests succeeded! :white_check_mark:
@hellobontempo I think we've reached a consensus that this is the way to go. Do you mind doing also the second part in this PR, which is to remove the guards too? In this way there is a single ticket and it's easier to track the changes and why. Thanks
@hellobontempo I think we've reached a consensus that this is the way to go. Do you mind doing also the second part in this PR, which is to remove the guards too? In this way there is a single ticket and it's easier to track the changes and why. Thanks
Yes! Absolutely. I'm a little busy feature testing until code freeze next Friday but I can update afterward. Feel free to takeover the PR/branch if this is blocking you until then 😄
Build Results: All builds succeeded! :white_check_mark: