Cristiano Rastelli

Results 46 comments of Cristiano Rastelli

@alex-ju in the context of https://github.com/hashicorp/design-system/pull/2205 I've added this commit, can you check it's OK? thanks https://github.com/hashicorp/design-system/pull/2104/commits/eb122da536531a1a5cb9853990c8f55ce43b6cd4

For context and future reference: after @aklkv has pushed the patch for the `ember-modifier` signature, @NullVoxPopuli commented [in this GitHub issue](https://github.com/ember-modifier/ember-modifier/issues/774#issuecomment-2198126063) and [in this Discord thread](https://discord.com/channels/480462759797063690/491905849405472769/1256578444981043240). So @aklkv force pushed...

@aklkv @natmegs @WenInCode I've added as reviewers to this PR because I likely touched code you implemented, so... feel free to review or not, as you prefer (don't feel obliged...

> I see that in this PR we change both the argument order in signatures (from alphabetical to match the order we currently have in the website) and the order...

> not something for this PR, more of a thing for our backlog to revisit would be OK to add something to the https://github.com/hashicorp/design-system/pull/2087 (I can add a suggestion) for...

> yes, that sounds good! https://github.com/hashicorp/design-system/pull/2087/files#r1604785808

@alex-ju @KristinLBradley @MelSumner I've noticed that many (most?) of my comments now that the branch has been rebased are "lost" in the "Files changed" tab, so if you want to...

@natmegs now that @aklkv PR #2109 has been merged, I _think_ this draft PR can be closed right? (they do the same thing if I'm not wrong).

@alex-ju in the context of https://github.com/hashicorp/design-system/pull/2205 I've added this commit, can you check it's OK? thanks https://github.com/hashicorp/design-system/pull/2106/commits/01ac7fab76bd18216fedc175ecd991bc0f98c9f7