design-system
design-system copied to clipboard
hashicorp
`PopoverPrimitive` - Convert to TypeScript
:pushpin: Summary
❌ Currently it doesn't compile because of an error I need to investigate ❌
Converts PopoverPrimitive to TypeScript.
Depends on #2103 and #2104.
:link: External links
Jira ticket: https://hashicorp.atlassian.net/browse/HDS-3339
👀 Component checklist
- [ ] Percy was checked for any visual regression
- [ ] A changelog entry was added via Changesets if needed (see templates here)
:speech_balloon: Please consider using conventional comments when reviewing this PR.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| hds-showcase | ✅ Ready (Inspect) | Visit Preview | Jul 3, 2024 7:22pm |
| hds-website | ✅ Ready (Inspect) | Visit Preview | Jul 3, 2024 7:22pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
For context and future reference: after @aklkv has pushed the patch for the ember-modifier signature, @NullVoxPopuli commented in this GitHub issue and in this Discord thread.
So @aklkv force pushed a commit to undo the changes he made, and remove the { eager: true } from our code. To preserve the history, I preferred to revert the changes and have distinct commits for each operation (the final code remains the same)