design-system icon indicating copy to clipboard operation
design-system copied to clipboard

Published 20 hours ago • verified publisher icon hashicorp

Modifier `hds-anchored-position` - Convert to TypeScript

Open didoo opened this issue 9 months ago • 1 comments

:pushpin: Summary

❌ Currently it doesn't compile because of an error I need to investigate ❌

Converts the hds-anchored-position modifier to TypeScript

:link: External links

Jira ticket: https://hashicorp.atlassian.net/browse/HDS-3338

👀 Component checklist

  • [ ] Percy was checked for any visual regression
  • [ ] A changelog entry was added via Changesets if needed (see templates here)

:speech_balloon: Please consider using conventional comments when reviewing this PR.

didoo avatar May 16 '24 14:05 didoo

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Jul 3, 2024 7:20pm
hds-website ✅ Ready (Inspect) Visit Preview Jul 3, 2024 7:20pm

vercel[bot] avatar May 16 '24 14:05 vercel[bot]

Is this branch meant to be pointed to main? I don't see the register-event modifier depending on it

@alex-ju there's only a tiny dependency, but also it helps me in remembering in which order to the rebase (there are four PRs related)

didoo avatar May 21 '24 09:05 didoo

@alex-ju in the context of https://github.com/hashicorp/design-system/pull/2205 I've added this commit, can you check it's OK? thanks https://github.com/hashicorp/design-system/pull/2104/commits/eb122da536531a1a5cb9853990c8f55ce43b6cd4

didoo avatar Jul 02 '24 15:07 didoo