Joel Dickson

Results 26 issues of Joel Dickson

RE: https://devblogs.microsoft.com/dotnet/introducing-the-new-microsoftdatasqlclient/

Add support for optional header that contains a guid that generated per request The idea is the target api can use this to detect a retry from the rr library...

Autofac has this ```csharp /// /// When implemented by a component, an instance of the component will be resolved /// and started as soon as the container is built. Autofac...

enhancement

For issue #15

based on feedback https://github.com/agoda-com/Agoda.IoC/pull/11#issuecomment-828111770 I think we can refactor this to be a be more elegant, currently its a foreach with a if/elseif/else, which isn't "always" bad, but i think...

bug

# Feature request ## Type - [x] - Enhancement - completely new feature - [ ] - Improvement - make what we have better ## Is your feature request related...

enhancement

The reasoning behind this one is around making code more readable. I'm note sure if you can outright say the elseif is always bad. But many cases where we see...

# Feature request ## Type - [x] - Enhancement - completely new feature - [ ] - Improvement - make what we have better ## Problem we are solving? We...

enhancement

https://github.com/agoda-com/AgodaAnalyzers/blob/67253b560c83f90b3f1a636ba7687af49c773458/src/Agoda.Analyzers/AgodaCustom/AG0019PreventUseOfInternalsVisibleToAttribute.cs#L41 If the target project has "test" in the name then not fail. We think this is acceptable for some test projects in some scenarios https://dotnetthoughts.net/dotnet-minimal-api-integration-testing/ Example here, its mandatory...