react-modal icon indicating copy to clipboard operation
react-modal copied to clipboard

Published 20 hours ago • verified publisher icon reactjs

[fixed] `appElement` detection...

Open diasbruno opened this issue 3 years ago • 1 comments

We can't use window.HTMLElement to check the appElement when combined with an iframe.

window.HTMLElement !== window.HTMLElement (on the iframe)

Fixes #871.

Changes proposed:

  • We can't use window.HTMLElement.

Upgrade Path (for changed or removed APIs):

Acceptance Checklist:

  • [x] The commit message follows the guidelines in CONTRIBUTING.md.
  • [x] Documentation (README.md) and examples have been updated as needed.
  • [x] If this is a code change, a spec testing the functionality has been added.
  • [ ] If the commit message has [changed] or [removed], there is an upgrade path above.

diasbruno avatar May 14 '21 14:05 diasbruno

Coverage Status

Coverage increased (+0.002%) to 85.602% when pulling 07ba54a6a01e8faeba7b134e425f3a997c8e3b73 on fix/appElement-property-detection into 76df16ba7cd7346156331c71a15d722c5f4e0db8 on master.

coveralls avatar May 14 '21 14:05 coveralls