Daniel Howe
Daniel Howe
but the question of words (specifically, parts of hyphenated words) that are not in the lexicon is still a problem... _pos_ case is a bit different as it doesn't require...
> But before that is done, maybe just turnoff the `keepHyphen` for now Can one of you take care of this (@Real-John-Cheung, ramble is highest priority now) ? - [x]...
do you have bandwidth @KarlieZhao ?
@Real-John-Cheung can you summarize me what you did here? I notice some of the tests are not correct, for example (for "state-of-the-art"): ```js eq(feats["syllables"], "s-t-ey-t-ah-v-dh-ah-aa-r-t"); ``` And how is "state-of-the-art"...
ok, so we need tests for hyphenated words where: - both parts are in lexicon - neither parts are in lexicon - one part is, the other isn't also, we...
some more words here: https://gist.github.com/dhowe/b384269c1ef88c32482a695403b772dd
I believe so, assuming those are the correct phonemes for the individual words as this is a tricky issue with many parts, please leave a marker in places where you've...
@Real-John-Cheung I've merged this with some of my own refactors -- can you sync with java?
@Real-John-Cheung @KarlieZhao seems this fix for hyphens has broken RiTa on Safari (especially problematic for iOS), as [the regex here](https://github.com/dhowe/ritajs/blob/master/src/tokenizer.js#L71) uses lookbehinds which Safari does not support See the ticket...
this may be resolved by simply adding 'nn' as a 2nd tag for 'there' in the lexicon, give it a try...