Daniel Howe
Daniel Howe
a good place to start would be the alignment tests in `https://github.com/processing/p5.js/blob/dev-2.0/test/manual-test-examples/type/index.html` eventually we will also need pixel-based tests like those here: https://github.com/processing/p5.js/blob/dev-2.0/test/unit/visual/cases/typography.js
Sorry, did you make this PR against the dev-2.0 branch ?
> Yes sir, the PR is currently targeting dev-2.0. Should I change the base branch to main instead, or would you prefer I rebase my changes on top of dev-2.0?...
both of these PR's need to target `dev-2.0` as we're not adding features to v1.x (which his still `main`) at this point
> Hi @osteele and @dhowe, sir, I have raised new PRs can you please review them. Should I close these two PRs? yes please and thanks for your work!
@Vansh0204 have you created tests for this feature?
a good place to start would be the alignment tests in `https://github.com/processing/p5.js/blob/dev-2.0/test/manual-test-examples/type/index.html` eventually we will also need pixel-based tests like those here: https://github.com/processing/p5.js/blob/dev-2.0/test/unit/visual/cases/typography.js
add option to sync with system light/dark mode