Dhia Ayachi
Dhia Ayachi
Closed in favour of https://github.com/hashicorp/consul/pull/14132
@mkeeler I undusted this PR, if you happen to have some spare time. I had to create a new one and close https://github.com/hashicorp/consul/pull/12182 because of some git weirdness but I...
@mkeeler @jkirschner-hashicorp I did some changes to this based on your comments. Please take a look when you have time. @mkeeler I implemented this as a GRPC endpoint. I tried...
Commits between OSS and ENT need to be 1:1 but PR don't need to as we can have only 1 PR that merge multiple changes from OSS to ENT. Currently...
@kyessenov reading the comment about `server_name` it say: ``` // If non-empty, a list of server names (e.g. SNI for TLS protocol) to consider when determining // a filter chain...
I'm new to envoy so I'm probably understanding this wrong. I thought that the http inspector filter is executed for every request before the filter chain match. From what you're...
@JadhavPoonam we need to add retries in the server RPC for the rate limiter errors, this is to cover the case of direct HTTP to a server.
> Thanks for fixing this :D! I think you're just missing a space separated case in your tests [This](https://github.com/hashicorp/consul-k8s/blob/4c471dd4addd60f171c46b717d26648eff01f2c1/control-plane/connect-inject/webhook/container_env_test.go#L70-L70) test case should cover it
Hi @jakubgs, Thank you for the contribution and sorry for the delay on this. I went through the changes and it look good, the only missing piece would be a...
@jakubgs Yes a good point, let me dig a bit to see if we can intercept the update somehow, or if we can test at a lower level by mocking...